Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 353945 - AbstractFilterActionContributor not applied after restart
Summary: AbstractFilterActionContributor not applied after restart
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 2.0.1   Edit
Hardware: Macintosh Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: SR2   Edit
Assignee: Jan Koehnlein CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-04 19:35 EDT by Dénes Harmath CLA
Modified: 2017-09-19 18:01 EDT (History)
3 users (show)

See Also:
sebastian.zarnekow: indigo+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dénes Harmath CLA 2011-08-04 19:35:42 EDT 
Build Identifier: I20110613-1736

In Xtext 2.0.1, although AbstractFilterActionContributor reloads its state correctly upon restart, the filter isn't applied.
(Note that this issue remains in spite of https://bugs.eclipse.org/bugs/show_bug.cgi?id=342682 being fixed.)

Reproducible: Always

Steps to Reproduce:
1. Open an Xtext file, and in the Outline, enable Show / Hide terminal rules.
2. Restart Eclipse.
3. Although Show / Hide terminal rules is enabled, terminal rules are still visible.
Comment 1 Dénes Harmath CLA 2011-08-04 19:37:15 EDT 
An obvious workaround is to call 

stateChanged(isPropertySet());

in AbstractFilterOutlineContribution#register, but I don't know whether this is the optimal way to do it.
Comment 2 Sebastian Zarnekow CLA 2011-08-16 17:13:21 EDT 
Scheduled for 2.1
Comment 3 Jan Koehnlein CLA 2011-10-14 05:58:54 EDT 
Refreshing the tree after registering all actions did the job.

Pushed to MASTER.
Comment 4 Karsten Thoms CLA 2017-09-19 17:50:08 EDT 
Closing all bugs that were set to RESOLVED before Neon.0
Comment 5 Karsten Thoms CLA 2017-09-19 18:01:05 EDT 
Closing all bugs that were set to RESOLVED before Neon.0