Community
Participate
Working Groups
+++ This bug was initially created as a clone of Bug #352196 +++ In the mentioned method the input stream 'in' is closed in the finally block, and any exceptions catched. It can be that 'in' is null, which raises a NullPointerException. Of course this one is catched by the empty catch block, but I think this situation should be proven explicitly. I have usually an exception breakpoint on NullPointerException on when debugging code, and I usually expect NPEs only in the code that I want to debug. So please make this a bit more safer: =============================== try { f.close(); } catch (Exception e) { } try { in.close(); } catch (Exception e) { =============================== Replace by: try { if (f!=null) f.close(); } catch (Exception e) { } try { if (in!=null) in.close(); } catch (Exception e) {
Cloned for backport to 3.7.1
Released to 3.7.1
As per http://www.eclipse.org/eclipse/development/plans/freeze_plan_3_7_1.php this bug needs a review+ on the patch from another committer and a review+ from a component lead to be committed into 3.7.1. Ankur and Dani, please review.
+1
Fix is released for 3.7.1. Ankur's review satisfies the SR1 freeze requirements.
Verified