Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 353797 - isDetach incorrectly assumes oldValues and currentValues are List type
Summary: isDetach incorrectly assumes oldValues and currentValues are List type
Status: RESOLVED FIXED
Alias: None
Product: Data Tools
Classification: Tools
Component: Connectivity (show other bugs)
Version: 1.9.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.10   Edit
Assignee: Brian Payton CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-03 12:59 EDT by Patrick Casteel CLA
Modified: 2012-05-31 17:08 EDT (History)
1 user (show)

See Also:

Attachments
Proprosed fix (1.73 KB, text/plain)
2011-08-03 13:03 EDT, Patrick Casteel CLA 		bpayton: iplog+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Casteel CLA 2011-08-03 12:59:28 EDT 
Build Identifier: 3.4.2

In org.eclipse.datatools.connectivity.sqm.internal.core.rte.fe.GenericDeltaDdlGenerator, isDetach() assumes oldValues and currentValues are List type. This is not a safe assumption since getOldValue returns Object. In the case of DB2 temporal tables, this could return type Table for the historyTable field.

See attached file for modified code.


Reproducible: Always

Steps to Reproduce:
This can only be reproduced currently on an unreleased product.
Comment 1 Patrick Casteel CLA 2011-08-03 13:03:30 EDT 
Created attachment 200838 [details]
Proprosed fix
Comment 2 Brian Payton CLA 2012-05-15 21:53:06 EDT 
OK, the fix looks good.  I've applied it to DTP 1.10.  Here's the Git commit record:
http://git.eclipse.org/c/datatools/org.eclipse.datatools.connectivity.git/commit/?id=9fbeeeee7a10fbab02b0c98cb2ca455472e9bb1f
Comment 3 Brian Payton CLA 2012-05-15 21:53:56 EDT 
Resolving as fixed...