Community
Participate
Working Groups
Build Identifier: 0.13.0-SNAPSHOT I've created a first try at implementing site-deploy for eclipse-repository projects so you can upload your Eclipse update sites to web servers using the Maven wagons: https://github.com/sonatype/sonatype-tycho/pull/8 Reproducible: Always Steps to Reproduce: N/A
IMHO this is just a workaround for the broken/missing Tycho dependencies story [1]. Conceptionally, I don't see how p2 repositories fit into the Maven Site concept - but I'm not an expert on Maven sites. [1] https://issues.sonatype.org/browse/TYCHO-335
Tobias, could you expand how this change is a work around? Would the proposed Nexus plugin you mention in TYCHO-335 allow users to install from deployed Eclipse repositories? I also note that ta special Nexus plugin also seems like a workaround: not all of us have the infrastructure to host Nexus when other plugin developers can host update sites using a simple HTTP server.
Sure. But then just configure wagon to upload the p2 repository to the place where you like it. (I don't really know wagon, but this should be possible.) Don't copy binaries into the documentation, just because that documenation happens to be uploaded to a server. This is a hack/workaround. You are free to do this in your projects, but we won't make this the default in Tycho.
Wow, rude and dismissive. It took days for anyone to look at this ticket and you close it without any real discussion. I'll think twice about contributing and patches to your project.
Sorry, I didn't mean to sound that harsh. Your solution fills in for the missing dependency story, so it is in fact valuable, but I don't think we should make this the default. As far as I know, Maven site is meant for documentation, and not for delivering binaries. What I could do however is integrate your new Mojo in the tycho-p2-extras-plugin (in the tycho-extras sub-project). The change is good (and even has a test :) so I would like to take it - if you think this is helpful without the change to the default lifecycle. We have to follow the legal process, so you would need to attach the change as patch to this bug, and answer the following questions: Did you author 100% of the code yourself? Do you licences it under the EPL? Do you have the permission to licence it under the EPL? Who owns the copyright to it? (This is typically your employer.)
I think Tycho should allow for the "site" and "site-deploy" build to include the repository files as a "sensible default" Maven "site" is used for deploying web sites in maven so it would fit into the concept. Although ideally it should support deployment to a p2 repository using the following snippet to the pom.xml <distributionManagement> <repository> <id>corp1</id> <name>Corporate Repository</name> <url>scp://repo/maven2</url> <layout>p2</layout> <=== DOES NOT EXIST YET </repository> </distributionManagement> Openning up #401078 for the above enhancement
this usecase is covered by mvn deploy and http://wiki.eclipse.org/Tycho/Nexus_Unzip_Plugin Frankly maven site is for generating and uploading documentation, that's a completely different story.
The solution appears to require having a Nexus server to be set up. What I am looking for is a sensible default that Eclipse plug-in developers can simply deploy things to without having to resort to Maven Antrun or relying on plug-ins like maven-upload-plugin (http://git.eclipse.org/c/m2e/m2e-core.git/tree/org.eclipse.m2e.site/pom.xml) that is not really standard and require explicit configuration. It should be driven from data in pom.xml similar to the suggestion I had in 401078. Even if there is no such thing as a "p2" repository, at the very least provide something like "p2-update-site" or something that we can deploy to without explicit step by step instructions on the POM via antrun or the ilk.
A Nexus server is a sensible default for a Maven project. I don't see the need that Tycho adds another "standard" beyond that. If you don't like the Nexus option (which does not require any extra configuration on project side), you can always use other plug-ins, create your own plug-in, or even you own build extension.
