Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 353714 - content assist decorated
Summary: content assist decorated
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Xiao Bin Chen CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-03 05:06 EDT by Xiao Bin Chen CLA
Modified: 2017-02-23 14:14 EST (History)
6 users (show)

See Also:


Attachments
Design draft for this work item (44.00 KB, application/msword)
2012-01-03 22:44 EST, Xiao Bin Chen CLA
no flags Details
design v0.2 (76.50 KB, application/msword)
2012-01-04 22:50 EST, Xiao Bin Chen CLA
no flags Details
icon for private function (868 bytes, image/gif)
2012-01-09 05:31 EST, Xiao Bin Chen CLA
no flags Details
Design v0.3 (32.26 KB, image/png)
2012-01-10 00:31 EST, Xiao Bin Chen CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xiao Bin Chen CLA 2011-08-03 05:06:32 EDT
Build Identifier: 0.7

We need to add decorated for each proposal.(like icon to diff each function field etc)

Reproducible: Always
Comment 1 Xiao Bin Chen CLA 2012-01-03 22:44:50 EST
Created attachment 208977 [details]
Design draft for this work item

We need to discuss on this work item for the icon will be used in CA.
Comment 2 Brian Svihovec CLA 2012-01-04 09:57:12 EST
Can you provide some examples from existing Eclipse tooling where these types of icons are provided (i.e. JDT, etc)?
Comment 3 Will Smythe CLA 2012-01-04 10:08:27 EST
I agree that consistency with other Eclipse tooling (specifically the Java tools) is *really* important.
Comment 4 Tony Chen CLA 2012-01-04 22:16:36 EST
I think we can reuse these icons we display in outline view so that the consistent icon is used to represent EGL types.
Comment 5 Will Smythe CLA 2012-01-04 22:26:29 EST
We should then ensure the icons in the EGL Outline view are reasonably consistent with the Java tools.
Comment 6 Xiao Bin Chen CLA 2012-01-04 22:49:09 EST
I think we should use existing edt icons. Because EGL language is different from java,js or other language. And those proposals given by Content Assist are OUR EGL language specific element.

And those icons are already used by RBD&EDT in outline view or other view.


So , I think we should consistency with other UI component of EDT.

I have updated the design document.which provide some icons used in edt.
Comment 7 Xiao Bin Chen CLA 2012-01-04 22:50:41 EST
Created attachment 209048 [details]
design v0.2
Comment 8 Brian Svihovec CLA 2012-01-05 14:58:33 EST
The screen captures added in version 2 of this document are exactly what I was going to request.  Thanks.

Questions/Comments:
* It looks like our outline view does not distinguish between private and public variables and functions with a different icon.  We should fix this in both the outline view and in the content assist window.  [A new enhancement can be opened for the outline view]

* Please include the icon that will be used for a Template

* I think we should use something similar to the JDT Annotation icon (@) for annotations

* We may want to consider placing 'badges' on certain icons if they have multiple meanings (i.e. the EGL Package Icon that appears on the Folder icon for an EGLSource folder).  For example, a variable that represents a service binding or a data binding might be displayed as a Variable icon with a particular 'badge' so that users can differentiate between those and regular variables (e.g. records, primitives, etc).  Theresa would need to comment here on the possibility of this violating UI guidelines.
Comment 9 Xiao Bin Chen CLA 2012-01-06 03:26:52 EST
1>https://bugs.eclipse.org/bugs/show_bug.cgi?id=368004 was created for outline view
2>I will use jdt's template & annotation icons for edt template annotation, If we all agree with it.

The third one, waiting for Theresa's comment

Thanks.
Comment 10 Xiao Bin Chen CLA 2012-01-09 05:30:29 EST
This workitem need a "icon" for private function. So far, I change the color of no private function "icon". Don't know if it's ok.
Comment 11 Xiao Bin Chen CLA 2012-01-09 05:31:24 EST
Created attachment 209196 [details]
icon for private function
Comment 12 Brian Svihovec CLA 2012-01-09 09:15:38 EST
Will and Theresa, I will let you guys have someone create us an icon if that's possible.
Comment 13 Xiao Bin Chen CLA 2012-01-10 00:31:09 EST
Created attachment 209240 [details]
Design v0.3
Comment 14 Xiao Bin Chen CLA 2012-01-10 00:32:24 EST
Add some new icon into the design ,include template,local variable, private variable,annotation,private function etc.
Comment 15 Theresa Ramsey CLA 2012-01-10 09:45:27 EST
checking with Kim, the visual designer to see if she can create an icon for us.
Comment 16 Brian Svihovec CLA 2012-01-17 09:59:11 EST
Xiao Bin - go ahead and open a new enhancement to replace the existing private function icon with the real icon, and then close this one as completed.  You can target the new icon task for .8 I2.
Comment 17 Xiao Bin Chen CLA 2012-01-17 20:39:21 EST
https://bugs.eclipse.org/bugs/show_bug.cgi?id=368901 was opened for replacing existing private function icon

Change the enhancement status to resolved.
Comment 18 Xiao Bin Chen CLA 2012-02-29 00:09:37 EST
verified in   
EGL Web Developer Tools	0.8.0.v201202280901-1Co-FjuJ6QMNSP3ynscd8h8C