Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 35371 - More flexibility building a plugin/fragment
Summary: More flexibility building a plugin/fragment
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 enhancement (vote)
Target Milestone: 3.2 M3   Edit
Assignee: pde-build-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-03-20 10:10 EST by Pascal Rapicault CLA
Modified: 2005-10-07 11:42 EDT (History)
2 users (show)

See Also:

Attachments
custom build targets at plugin level (31.80 KB, patch)
2005-10-06 10:43 EDT, Andrew Niefer CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Rapicault CLA 2003-03-20 10:10:20 EST 
With the new build mechanism, the flexibility in adding custom steps is only 
provided at the level of the build.xml which is to big grain.

It could be interesting to provide a support for customTargets at the plugin 
level. 

Because you do not want to have to write empty customTargets, a good solution 
seems to provide in the build.properties a customTargets property.
If the property is false, no call the customTargets are done, otherwise calls 
to a customTarget provided by the user are done.

If we go a step further, the customTargets is indeed a "replacement" for the 
property custom.
Comment 1 DJ Houghton CLA 2003-11-20 13:15:51 EST 
Changing bug assignment to pde-build-inbox. (pde-core-inbox is obsolete)
Comment 2 Pascal Rapicault CLA 2004-05-10 11:17:36 EDT 
Given the little value add, this won't be adressed for 3.0.
Comment 3 Pascal Rapicault CLA 2005-08-26 08:44:16 EDT 
One use case is elaborated in bug #107190.
Comment 4 Jörg von Frantzius CLA 2005-10-06 10:09:01 EDT 
This is important for application builds that require bytecode-enhancing, e.g.
for EJB3 or JDO. Given the new Eclipse technology projects ejb-orm and
jsr220-orm, this requirement is becoming more common.

Has there any decision been taken yet or has there any development been going on
concerning this and related bugs?
Comment 5 Pascal Rapicault CLA 2005-10-06 10:22:36 EDT 
Yes. We have a patch on the way.
Comment 6 Andrew Niefer CLA 2005-10-06 10:43:49 EDT 
Created attachment 27944 [details]
custom build targets at plugin level

Attached is a patch which provides this functionality.	In your
build.properties, set customBuildCallbacks=<filename>. 
templates/customBuildCallbacks.xml is provided as a template showing the
available targets.
Comment 7 Jörg von Frantzius CLA 2005-10-06 12:43:16 EDT 
(In reply to comment #6)
> Created an attachment (id=27944) [edit]
> custom build targets at plugin level
> 
> Attached is a patch which provides this functionality.	In your
> build.properties, set customBuildCallbacks=<filename>. 
> templates/customBuildCallbacks.xml is provided as a template showing the
> available targets.

Yipee! I see the end of my build nightmares nearing! Would you guys mind telling
here when this is part of HEAD, so I can watch out for the next integration
build that includes it?

Thanks a lot,
Jörg
Comment 8 Pascal Rapicault CLA 2005-10-06 12:50:26 EDT 
Keep on tracking this bug (we'll try to have it release for M3).
Comment 9 Pascal Rapicault CLA 2005-10-07 11:42:01 EDT 
Fix released in HEAD.
It will be part of the next I build.