Community
Participate
Working Groups
Build Identifier: 20110615-0604 When using ctrl+space to view attributes proposals in a tag-file declaration in the jsp editor it should show only the attributes referenced in the tag-file. Inspecting "org.eclipse.jst.jsp.core.internal.contentmodel.tld.CMDocumentFactoryTLD.createElementDeclaration(CMDocumentImpl, Element, String)", one could see that when the tag-file is inside a jar, it tries to load all tag-files from that jar. That seems to be incorrect, since it should load only the tag-file referenced in the third argument "path" from "createElementDeclaration". By loading all tag-files using "org.eclipse.jst.jsp.core.internal.contentmodel.tld.CMDocumentFactoryTLD.loadTagFile(CMElementDeclarationImpl, IFile, boolean, InputStream)", the attribute information (and all other metadata information) of all tag-files is mixed/overwritten in the same instance of "org.eclipse.jst.jsp.core.internal.contentmodel.tld.CMElementDeclarationImpl", instead of containing only the information associated with the tag-file referenced by "path" argument of "createElementDeclaration". Reproducible: Always Steps to Reproduce: 1. Add a external jar to your Web project containing 2 custom tag-files with different attributes. 2. Create a jsp and declare one the tags. 3. Press ctrl+space and inspect the attributes proposed by the content assist, all the attributes from tag 1 and 2 will show.
Created attachment 200754 [details] Patch to address the problem of loading all tag-files inside the same jar, "mixing" meta data information.
Thank you very much for your patch, Andre! I've released the changes.
(In reply to comment #2) > Thank you very much for your patch, Andre! I've released the changes. You're welcome!
