Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 353614 - fixupRanges needs to be called in DwarfInfoReader after using LineEntries as they may be wrong
Summary: fixupRanges needs to be called in DwarfInfoReader after using LineEntries as ...
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-edc (show other bugs)
Version: 8.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Ken Ryall CLA
QA Contact: Ken Ryall CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-02 12:03 EDT by Daniel Thomas CLA
Modified: 2012-05-22 20:36 EDT (History)
2 users (show)

See Also:

Attachments
Fixup the ranges after using line entries as a first attempt (1.05 KB, patch)
2011-08-02 12:04 EDT, Daniel Thomas CLA 		no flags Details | Diff
Additionally move compileUnitHeader registration earlier as this is required. (1.96 KB, patch)
2011-08-03 04:48 EDT, Daniel Thomas CLA 		cdtdoug: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Thomas CLA 2011-08-02 12:03:19 EDT 
Build Identifier: 

DwarfInfoReader uses the line entries table in setupAddresses to work out what ranges of memory are covered by the compile unit. Unfortunately some compilers do not correctly garbage collect line entry tables for functions which have been garbage collected resulting in erroneous line entry regions starting at or near 0.
Calling fixupRanges after using the line entry tables to initially compute the start and end address fixes this up and removes the invalid region(s).

I have a patch which adds this.

Reproducible: Always
Comment 1 Daniel Thomas CLA 2011-08-02 12:04:08 EDT 
Created attachment 200744 [details]
Fixup the ranges after using line entries as a first attempt
Comment 2 Daniel Thomas CLA 2011-08-03 04:48:18 EDT 
Created attachment 200781 [details]
Additionally move compileUnitHeader registration earlier as this is required.
Comment 3 Kirk Beitz CLA 2011-08-06 05:01:54 EDT 
the patch has been merged and nominally tested in our local source base.  waiting for final review and merge to eclipse edc git repository by committer Ken Ryall.