Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 353605 - Add support for merging and fixing up RangeLists and fix empty RangeList bug
Summary: Add support for merging and fixing up RangeLists and fix empty RangeList bug
Status: RESOLVED WONTFIX
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-edc (show other bugs)
Version: 8.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Ken Ryall CLA
QA Contact: Ken Ryall CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-02 11:30 EDT by Daniel Thomas CLA
Modified: 2019-12-30 18:40 EST (History)
2 users (show)

See Also:


Attachments
Add support for rangelist merging, fixing up and not returning empty rangelists (8.36 KB, patch)
2011-08-02 11:31 EDT, Daniel Thomas CLA
no flags Details | Diff
Better patch which only upates rangelist using children also updating start and end addresses (8.43 KB, patch)
2011-08-02 11:37 EDT, Daniel Thomas CLA
no flags Details | Diff
Patch to add proper merging support, tests on this, use it and bug fixes (14.81 KB, patch)
2011-08-04 05:46 EDT, Daniel Thomas CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Thomas CLA 2011-08-02 11:30:49 EDT
Build Identifier: 

There were TODOs in Scope asking for the implementation of proper merging which is now done.

fixupRanges in Scope only fixed high and low addresses and took no account of the ranges of the children it is fixing up.

DwarfInfoReader would return empty RangeLists when null is the canonical form for an empty range list.

Reproducible: Always
Comment 1 Daniel Thomas CLA 2011-08-02 11:31:28 EDT
Created attachment 200731 [details]
Add support for rangelist merging, fixing up and not returning empty rangelists
Comment 2 Daniel Thomas CLA 2011-08-02 11:37:50 EDT
Created attachment 200733 [details]
Better patch which only upates rangelist using children also updating start and end addresses
Comment 3 Daniel Thomas CLA 2011-08-04 05:46:46 EDT
Created attachment 200895 [details]
Patch to add proper merging support, tests on this, use it and bug fixes

This patch first adds support for proper merging of IRangeLists (as a static method in RangeList this time as that is a better location)
Then it adds tests to check that this and other RangeList functionality works, in the process a bug in the isInRange function was found and fixed.
Then it uses this rangelist merging functionality to make fixupRanges fixup the range lists as well as the start and end addresses.
Then fix a bug in DwarfInfoReader where it would return a non-null RangeList which was empty rather than returning null (which means empty in the RangeList context).
Comment 4 Kirk Beitz CLA 2011-08-06 16:39:30 EDT
i've moved the TestRangeList part of the patch to org.eclipse.cdt.debug.edc.tests.

with that change, the patch has been merged and nominally tested in our local source base. waiting for final review and merge to eclipse edc git repository by
committer Ken Ryall.
Comment 5 Jonah Graham CLA 2019-12-30 18:40:08 EST
(this is part of a batch change)

The Eclipse CDT EDC (https://wiki.eclipse.org/CDT/cdt-debug-edc) is now obsolete and has not had any active development since 2011. Therefore the still open bugs are being marked as wontfix.

The git repo for the project still exists for posterity at https://git.eclipse.org/c/cdt/org.eclipse.cdt.edc.git/