Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 353599 - ArrayType does not generate its name using its bounds
Summary: ArrayType does not generate its name using its bounds
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-edc (show other bugs)
Version: 8.0   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: ---   Edit
Assignee: Ken Ryall CLA
QA Contact: Ken Ryall CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-02 10:41 EDT by Daniel Thomas CLA
Modified: 2012-05-22 20:35 EDT (History)
2 users (show)

See Also:

Attachments
Patch to add support for generating the ArrayType name (3.96 KB, patch)
2011-08-02 10:42 EDT, Daniel Thomas CLA 		no flags Details | Diff
Add a test that checks this behaviour (3.64 KB, patch)
2011-08-04 07:56 EDT, Daniel Thomas CLA 		no flags Details | Diff
Patch to add support for generating the ArrayType name (3.83 KB, patch)
2011-08-05 06:59 EDT, Daniel Thomas CLA 		cdtdoug: iplog+
Details | Diff
Add tests on ArrayType generally (4.59 KB, patch)
2011-08-05 07:00 EDT, Daniel Thomas CLA 		cdtdoug: iplog+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Thomas CLA 2011-08-02 10:41:45 EDT 
Build Identifier: 

An array int[4][5] should have the name "int[4][5]" rather than "int[]", "int" or "int[4]" and I have a patch which adds support for correctly generating the name of the ArrayType.

Reproducible: Always
Comment 1 Daniel Thomas CLA 2011-08-02 10:42:13 EDT 
Created attachment 200724 [details]
Patch to add support for generating the ArrayType name
Comment 2 Daniel Thomas CLA 2011-08-04 07:56:16 EDT 
Created attachment 200908 [details]
Add a test that checks this behaviour
Comment 3 Daniel Thomas CLA 2011-08-05 06:59:57 EDT 
Created attachment 200967 [details]
Patch to add support for generating the ArrayType name

Previous patch had a broken import.
Comment 4 Daniel Thomas CLA 2011-08-05 07:00:59 EDT 
Created attachment 200968 [details]
Add tests on ArrayType generally

Also tests changes in: https://bugs.eclipse.org/bugs/show_bug.cgi?id=353611
Comment 5 Kirk Beitz CLA 2011-08-05 21:01:27 EDT 
the patch has been merged and nominally tested in our local source base.

the test case has been added instead to
org.eclipse.cdt.debug.edc.tests.ArrayBoundsTest
rather than as a separate regression test.

both are waiting for final review and merge to eclipse edc git repository by
committer Ken Ryall.
Comment 6 Kirk Beitz CLA 2011-08-06 16:34:36 EDT 
(In reply to comment #5)
> the test case has been added instead to
> org.eclipse.cdt.debug.edc.tests.ArrayBoundsTest
> rather than as a separate regression test.

as per patch for another Array type issue, this test is now part of org.eclipse.cdt.debug.edc.tests.TestArrayType