Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 353574 - Misc minor fixes to EDC
Summary: Misc minor fixes to EDC
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-edc (show other bugs)
Version: 8.0   Edit
Hardware: All Linux
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Ken Ryall CLA
QA Contact: Ken Ryall CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-02 09:16 EDT by Daniel Thomas CLA
Modified: 2012-05-22 20:34 EDT (History)
2 users (show)

See Also:

Attachments
Add patch of all these misc changes in 12 sections (19.36 KB, patch)
2011-08-02 09:17 EDT, Daniel Thomas CLA 		no flags Details | Diff
Patch with 10 misc fixes (16.36 KB, patch)
2011-08-04 07:06 EDT, Daniel Thomas CLA 		cdtdoug: iplog+
Details | Diff
Test on changes to scope (5.47 KB, patch)
2011-08-04 07:48 EDT, Daniel Thomas CLA 		cdtdoug: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Thomas CLA 2011-08-02 09:16:04 EDT 
Build Identifier: I20110613-1736

I have written 12 minor fixes to EDC:

1: Take account of the highAddress of a scope if the low addresses are equal
2: Use toHexAddress in CompileUnitScope as used elsewhere
3: Remove duplicate child methods from DwarfCompileUnit which repeat parent methods
4: Fix incorrect case in OpaqueTypeResolving which causes test to fail on Linux.
5: Consistently use lastSegment in TestDwarfReader as these give move legible errors
6: In DwarfInfoReader fix case where next() called without check on hasNext()
7: Use lastKey() in SortedMaps to avoid iterating through whole map
8: Log exceptions in TestUtils rather than ignoring them
9: Try adding a parameter to the parent function scope if found in a lexical block
10: Make typedefs in ModuleLineEntryProvider static
11: Make full use of super constructor in DwarfVariable
12: Add toString() method to Type

Further details can be found in the patch.

Reproducible: Always
Comment 1 Daniel Thomas CLA 2011-08-02 09:17:08 EDT 
Created attachment 200710 [details]
Add patch of all these misc changes in 12 sections
Comment 2 Daniel Thomas CLA 2011-08-04 07:06:34 EDT 
Created attachment 200898 [details]
Patch with 10 misc fixes

Removes changes 6 and 9 as these need to be filed as separate bugs.
Comment 3 Daniel Thomas CLA 2011-08-04 07:48:24 EDT 
Created attachment 200904 [details]
Test on changes to scope
Comment 4 Kirk Beitz CLA 2011-08-05 02:32:27 EDT 
for the most part, the patch looks good.

while these are all minor fixes, a couple of them are higher risk items than others.

after running through part of our local test-suite, i've committed all but #1 from the original description to our local repository for now, pending Ken Ryall's final look-see and merge to the eclipse edc git repository.


i'm awaiting some discussion from one of our other people who knows our local compiler quirks and what we're trying to live with insofar as the DWARF is concerned before merging item 1 from this list.  the use of 0-size regions and having to fix them up ourselves rings a bell with me, and so i'm afraid committing this may break certain things for us, but i'm not exactly certain whether this was the trouble spot or not.
Comment 5 Kirk Beitz CLA 2011-08-05 02:47:10 EDT 
also, w.r.t. the ScopeTest regression test, rather than beginning the regression suite just now, i've added all of this test to package org.eclipse.cdt.debug.edc.tests for regular JUnit regression testing like other current JUnit tests.

Ken Ryall will also perform the final review and merge of this item to the eclipse edc git repository.