Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 353568 - API Tools test failures in I20110729-1200
Summary: API Tools test failures in I20110729-1200
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.8 M1   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-02 08:26 EDT by Curtis Windatt CLA
Modified: 2011-08-15 12:50 EDT (History)
6 users (show)

See Also:

Attachments
Fix (14.58 KB, patch)
2011-08-03 17:06 EDT, Curtis Windatt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2011-08-02 08:26:47 EDT 
http://download.eclipse.org/eclipse/downloads/drops/I20110729-1200/

There are 48 failures.  Several are failures because a 1.7 JRE is not available.  We do not want to fail in this case.  It seems likely the Java 7 support is the cause of all the failures, though the tests passed locally.
Comment 1 Dani Megert CLA 2011-08-02 09:18:59 EDT 
I guess the same applies to 3.7 maintenance.
Comment 2 Kim Moir CLA 2011-08-03 10:48:55 EDT 
I didn't add the pde.api tools 1.7 fragment until this morning. Also, a 1.7 JDK is not available to the tests. Right now, we run the tests with a 1.6 VM.  I'll make the the JavaSE-1.7 property available to the tests.
Comment 3 Kim Moir CLA 2011-08-03 10:52:34 EDT 
Another question, why doesn't the BREE for the pde.api.tools.tests specify 1.7 if it is required to run the tests?
Comment 4 Curtis Windatt CLA 2011-08-03 11:02:51 EDT 
The intention was for the 1.7 tests to be optional. They should not fail when a 1.7 JRE is not available.  This was following the same code style as the 1.5 tests (at some point in the past the BREE was bumped to 1.5).
Comment 5 Curtis Windatt CLA 2011-08-03 13:20:34 EDT 
There are two separate issues:

1) Tests that require 1.7 compliance are not skipped.

2) Some tests import and build the RefProject which includes a class that uses 1.7 constructs.
Comment 6 Curtis Windatt CLA 2011-08-03 17:06:16 EDT 
Created attachment 200858 [details]
Fix
Comment 7 Curtis Windatt CLA 2011-08-03 17:21:18 EDT 
Patch applied to HEAD and released.

(1) is fixed by modifying the test suite creation to not include the Java 7 tests if no compatible JRE is available.  Thanks Mike.

(2) is fixed by moving the java 7 file into its own folder outside the typical usage test projects folder.  The java 7 test that needs that project imports it separately.

Investigating releasing the fix to 3.7.1
Comment 8 Curtis Windatt CLA 2011-08-03 17:58:04 EDT 
Released to R3_7_maintenance
Comment 9 Ankur Sharma CLA 2011-08-05 03:52:45 EDT 
No Java7 related failures in I20110803-1800
Comment 10 Dani Megert CLA 2011-08-05 03:57:12 EDT 
But there are API tools failures. What's causing those?
Comment 11 Ankur Sharma CLA 2011-08-05 05:36:08 EDT 
I know and I am looking into it and prima facie they are not Java7 related. No api tools test has failed across all platforms.
Comment 12 Dani Megert CLA 2011-08-05 05:37:53 EDT 
(In reply to comment #11)
> I know and I am looking into it
Is there a bug for that investigation?
Comment 13 Olivier Thomann CLA 2011-08-15 12:50:39 EDT 
(In reply to comment #12)
> Is there a bug for that investigation?
I guess this is bug 354017