Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 353563 - HttpDestinationQueueTest takes too long
Summary: HttpDestinationQueueTest takes too long
Status: RESOLVED FIXED
Alias: None
Product: Jetty
Classification: RT
Component: client (show other bugs)
Version: 7.4.2   Edit
Hardware: PC All
: P3 minor (vote)
Target Milestone: 7.5.x   Edit
Assignee: Thomas Becker CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-02 07:34 EDT by Thomas Becker CLA
Modified: 2011-08-29 17:27 EDT (History)
2 users (show)

See Also:

Attachments
patch created with git format-patch (10.39 KB, patch)
2011-08-02 09:28 EDT, Thomas Becker CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Becker CLA 2011-08-02 07:34:36 EDT 
Build Identifier: 

The provided patch will reuse the HttpClient to save runtime at the cost of some test coupling which does no harm in this case.
Also the timeout used has been reduced from 2s to 200ms. This might have side effects on some systems. So this patch needs thorough testing on different environments.

Reproducible: Always
Comment 1 Thomas Becker CLA 2011-08-02 09:28:46 EDT 
Created attachment 200712 [details]
patch created with git format-patch
Comment 2 Michael Gorovoy CLA 2011-08-29 17:27:36 EDT 
This patch has been applied in the beginning of the month. I suspect that most of the performance gain came from setting a short timeout rather when reusing HttpClient object.