Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 353553 - Rename readableNames.properties to avoid translation
Summary: Rename readableNames.properties to avoid translation
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.8 M6   Edit
Assignee: Ayushman Jain CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 352026 353780 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-08-02 05:49 EDT by Ayushman Jain CLA
Modified: 2012-03-12 10:21 EDT (History)
6 users (show)

See Also:

Attachments
proposed fix (26.46 KB, patch)
2011-08-02 05:53 EDT, Ayushman Jain CLA 		no flags Details | Diff
proposed fix 2 (932 bytes, patch)
2011-08-02 07:26 EDT, Ayushman Jain CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ayushman Jain CLA 2011-08-02 05:49:48 EDT 
Because of the Java 7 work, a new line has been added to readableNames.properties i.e. line 12: 
;opt=;

This fails CHKPII, and may also cause translation issues.
We should rename this file to something other than .properties since it has no business being translated.
Comment 1 Ayushman Jain CLA 2011-08-02 05:53:27 EDT 
Created attachment 200694 [details]
proposed fix

Changed name to readableNames.props
Comment 2 Ayushman Jain CLA 2011-08-02 05:59:23 EDT 
Released in HEAD for 3.8M1 and in R3_7_maintenance for 3.7.1
Comment 3 Ayushman Jain CLA 2011-08-02 07:09:27 EDT 
On further investigation it seems that translation of this file is necessary (looking at org.eclipse.jdt.internal.compiler.parser.Parser.readReadableNameTable(String) )

The parser also fails to initialize unless we use the *.properties extension. So, reverting for now. Will need to find another solution.
Comment 4 Dani Megert CLA 2011-08-02 07:20:17 EDT 
(In reply to comment #3)
> On further investigation it seems that translation of this file is necessary
> (looking at
> org.eclipse.jdt.internal.compiler.parser.Parser.readReadableNameTable(String) )

Please verify that it indeed works with a translated file, e.g. by installing the language packs for German and running with -nl de.

> The parser also fails to initialize unless we use the *.properties extension.
> So, reverting for now. Will need to find another solution.
For now, please just fix the key by escaping it. Given you already have the manual step to add the copyright, we can live with that until a better solution is available.
Comment 5 Ayushman Jain CLA 2011-08-02 07:26:08 EDT 
Created attachment 200702 [details]
proposed fix 2

Escaping the ;opt for CHKPII
Comment 6 Ayushman Jain CLA 2011-08-03 04:58:00 EDT 
(In reply to comment #4)
> (In reply to comment #3)
> > On further investigation it seems that translation of this file is necessary
> > (looking at
> > org.eclipse.jdt.internal.compiler.parser.Parser.readReadableNameTable(String) )
> 
> Please verify that it indeed works with a translated file, e.g. by installing
> the language packs for German and running with -nl de.

Tests pass with the German pack and CHKPII are also green (as confirmed by Dani).
Hence releasing in HEAD for 3.8M1 and in R3_7_maintenance for 3.7.1
Comment 7 Ayushman Jain CLA 2011-08-03 11:03:02 EDT 
*** Bug 353780 has been marked as a duplicate of this bug. ***
Comment 8 Olivier Thomann CLA 2011-08-15 12:37:20 EDT 
Seems to work fine.
Comment 9 Olivier Thomann CLA 2011-08-15 12:38:35 EDT 
*** Bug 352026 has been marked as a duplicate of this bug. ***
Comment 10 Satyam Kandula CLA 2011-08-25 11:12:37 EDT 
Verified for 3.7.1 RC2 using build M20110824-0800
Comment 11 Olivier Thomann CLA 2011-09-14 11:18:37 EDT 
Verified for 3.8M1.
Comment 12 Srikanth Sankaran CLA 2012-02-26 23:36:15 EST 
Per https://bugs.eclipse.org/bugs/show_bug.cgi?id=291040#c14,
reopening this. Since the fix is in a generated file, we must
fix the generator also. Ayush, let us try and get this in for
this week's I build if possible - Thanks,
Comment 14 Srikanth Sankaran CLA 2012-02-27 23:39:13 EST 
Raised bug 372694 with 3.8 M7 as target for fixing the
generating classes in the tools project.
Comment 15 Satyam Kandula CLA 2012-03-12 10:21:19 EDT 
Verified for 3.8M6 using code inspection.