Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 353518 - Translators exceptions are not shown to users
Summary: Translators exceptions are not shown to users
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Sequoyah (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-01 13:33 EDT by Marcelo Bossoni CLA
Modified: 2016-11-08 14:46 EST (History)
3 users (show)

See Also:

Attachments
Change some return values to let translators exceptions be displayed to users (22.54 KB, application/octet-stream)
2011-08-01 14:38 EDT, Marcelo Bossoni CLA 		wmg040: iplog+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcelo Bossoni CLA 2011-08-01 13:33:18 EDT 
Build Identifier: 

Any exceptions thrown by translators are just logged using the BaseLogger and are not displayed to users.

The localization framework should handle these exceptions and offer the right message to users.

Reproducible: Always

Steps to Reproduce:
1. Create a translator that throws some exception.
2. Run the translate action using that translator
3. The exception is never displayed unless you create a message dialog from within the translator code. This also cause two error dialogs being shown.
Comment 1 Marcelo Bossoni CLA 2011-08-01 14:38:46 EDT 
Created attachment 200666 [details]
Change some return values to let translators exceptions be displayed to users

This patch break some APIs because I'm using IStatus to handle the status/messages (the translated methods were returning booleans before) instead of Exceptions.