Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 353471 - wrong task submitted on Alt+s when editor area is split
Summary: wrong task submitted on Alt+s when editor area is split
Status: CLOSED MOVED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P2 major (vote)
Target Milestone: ---   Edit
Assignee: Sam Davis CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-31 15:02 EDT by Sam Davis CLA
Modified: 2012-07-20 17:44 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Davis CLA 2011-07-31 15:02:09 EDT
When the editor area is split, Mylyn does not handle it well:
* when activating a task, only editors in the active editor stack are closed
* when two task editors are active in different editor stacks
Comment 1 Sam Davis CLA 2011-07-31 15:03:37 EDT
What I wanted to say was: when two task editors are active in different editor stacks, the selection is not correctly set, so pushing alt+s always submits the same task, regardless of which editor is actually active.
Comment 2 Steffen Pingel CLA 2011-08-11 07:02:29 EDT
I can not reproduce the submit problem. For me submit is triggered on the active task editor. Can you provide steps to reproduce?

Handling of editor restore for split layout is tracked on bug 166644.
Comment 3 Sam Davis CLA 2011-08-29 20:25:58 EDT
It works in some cases but here's a way to reliably reproduce:
# open 2 tasks
# drag the second task below the first
# activate the first task
# push alt+s
# the second task is submitted.
Comment 4 Steffen Pingel CLA 2012-03-08 11:11:35 EST
Thanks for the bug report. Sam, let me know if you are interested in looking into this.
Comment 5 Sam Davis CLA 2012-03-08 15:11:37 EST
Sure, I will look into this.
Comment 6 Sam Davis CLA 2012-07-20 17:44:36 EDT
The reason this happens is that the label on the 2 submit buttons starts with '&' so (on Windows at least) pushing Alt+Shift+S is *sometimes* interpreted as Alt+S and therefore pushes one of those buttons instead of triggering the command via the keybinding. Boy was I confused when I saw it firing selection events on the button when it should have been firing the command!

Alt+S always seems to submit the most recently opened task editor, when more than one is visible. The fact that Alt+S has this behaviour seems like a platform bug, but it may be that editors just shouldn't define accelerators this way because it is ambigious when mulitple editors are visible at the same time. I wonder what e4 does in this case.

I am not able to reproduce the original bug at this moment, so I wonder if the problem was actually my wireless keyboard failing to send all three keys.
Comment 7 Eclipse Webmaster CLA 2022-11-15 11:45:08 EST
Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn