Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 353468 - [completion] completing a method binding inserts nested class by its binary name
Summary: [completion] completing a method binding inserts nested class by its binary name
Status: VERIFIED WORKSFORME
Alias: None
Product: Objectteams
Classification: Tools
Component: OTDT (show other bugs)
Version: 2.0   Edit
Hardware: Other Linux
: P3 normal (vote)
Target Milestone: 2.1 M5   Edit
Assignee: Stephan Herrmann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-31 11:34 EDT by Stephan Herrmann CLA
Modified: 2012-09-22 16:17 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2011-07-31 11:34:43 EDT 
In a role bound to org.eclipse.jdt.internal.corext.codemanipulation.StubUtility2
I was adding a method binding to 
createImplementationStub(ICompilationUnit, ASTRewrite, ImportRewrite, ImportRewriteContext, IMethodBinding, String, CodeGenerationSettings, boolean)
which rendered the signature with ImportRewrite$ImportRewriteContext
which certainly didn't compile.

Additionally, all types were mentioned using the fully qualified name,
which too is undesirable.
Comment 1 Stephan Herrmann CLA 2011-08-27 10:31:28 EDT 
Put on radar.
Comment 2 Stephan Herrmann CLA 2012-01-31 07:24:39 EST 
I've added CodeCompletionTest#testCreateMethodBinding1() along the lines of comment 0 (commit e85de3c3dfa8033bf81f31b8d3392d6c991e3b98).

However, neither using the test nor in real-life experiments against the exact method mentioned was I able to reproduce the problem. All imports were created properly, all types were referenced by the simple names.

There's a slight chance that recent improvements regarding import rewriting also fixed this.
Comment 3 Stephan Herrmann CLA 2012-09-22 16:17:47 EDT 
Verified using build 2.2.0.201209221349