Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 353464 - [Builder Participant] Persist information about managed resources
Summary: [Builder Participant] Persist information about managed resources
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 2.0.0   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 enhancement (vote)
Target Milestone: SR2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 354938 (view as bug list)
Depends on:
Blocks: 352473
  Show dependency tree
 
Reported: 2011-07-31 08:09 EDT by Sven Efftinge CLA
Modified: 2017-09-19 18:13 EDT (History)
3 users (show)

See Also:
sven.efftinge: indigo+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Efftinge CLA 2011-07-31 08:09:06 EDT
The default implementations of IBuilderParticipant should store the information about generated files between workbench sessions.
Comment 1 Sven Efftinge CLA 2011-08-10 06:27:46 EDT
Sebastian had the idea to attach special markers to the resources. This will attach the information about which file was generated by what participant directly to the lifecycle of the resource.
Comment 2 Knut Wannheden CLA 2011-08-10 10:44:23 EDT
I don't know about Eclipse markers as that's also a UI concept. But how about persistent properties? From IResource:

	public Map<QualifiedName,String> getPersistentProperties() throws CoreException;
	public String getPersistentProperty(QualifiedName key) throws CoreException;
	public void setPersistentProperty(QualifiedName key, String value) throws CoreException;
Comment 3 Sebastian Zarnekow CLA 2011-08-10 11:07:02 EDT
Don't know about persistent properties but markers don't seem to introduce dependencies to ui concepts: org.eclipse.core.resources.IResource.findMarker(long)

At a first glance, persistent properties may be a good fit, too, e.g. Eclipse uses them to store the last editor type that was used to open a file.
Markers have the advantage that one can search for all markers in a file system hierarchy by means of IResource#findMarkers() and each marker allows to navigate to the containing resource.

We should try to find a solution that allows to share the builder information across workspaces, e.g. as soon as devA commits generated code to the repo, the builder on devB's machine should know about that when the code is pulled from the repo.
Comment 4 Knut Wannheden CLA 2011-08-10 12:22:18 EDT
What I meant was that markers typically apear in views, but I suppose that that can be controlled using the marker type.

If the information is to be committed to the VCS repository I suppose project preferences would be another interesting fit.
Comment 5 Sven Efftinge CLA 2011-08-15 03:05:41 EDT
AFAIK markers are a UI-independent concept from the resources API. What you see in the UI are just representations of them (e.g. Annotations).
Comment 6 Sebastian Zarnekow CLA 2011-08-17 07:35:39 EDT
*** Bug 354938 has been marked as a duplicate of this bug. ***
Comment 7 Sebastian Zarnekow CLA 2011-08-23 12:54:37 EDT
Sven pushed a solution for this one to master.
Comment 8 Karsten Thoms CLA 2017-09-19 18:03:41 EDT
Closing all bugs that were set to RESOLVED before Neon.0
Comment 9 Karsten Thoms CLA 2017-09-19 18:13:49 EDT
Closing all bugs that were set to RESOLVED before Neon.0