Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 353433 - Copy Details - URL should falls back to connector.getTaskUrl if no taskUrl in ITask
Summary: Copy Details - URL should falls back to connector.getTaskUrl if no taskUrl in...
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 minor (vote)
Target Milestone: 3.7   Edit
Assignee: Thomas Ehrnhoefer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2011-07-29 12:17 EDT by Thomas Ehrnhoefer CLA
Modified: 2011-11-27 14:01 EST (History)
1 user (show)

See Also:

Attachments
changed file (4.59 KB, text/plain)
2011-07-29 13:08 EDT, Thomas Ehrnhoefer CLA 		no flags Details
mylyn/context/zip (38.29 KB, application/octet-stream)
2011-07-29 13:08 EDT, Thomas Ehrnhoefer CLA 		no flags Details
patch v1 (1.84 KB, patch)
2011-08-11 10:21 EDT, Thomas Ehrnhoefer CLA 		no flags Details | Diff
patch v2 (3.82 KB, patch)
2011-11-25 14:14 EST, Thomas Ehrnhoefer CLA 		steffen.pingel: iplog+
Details | Diff
mylyn/context/zip (6.32 KB, application/octet-stream)
2011-11-25 14:14 EST, Thomas Ehrnhoefer CLA 		no flags Details
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Ehrnhoefer CLA 2011-07-29 12:17:38 EDT 
Seems odd that even though this API exists, if a connector doesn't set the taskUrl in the ITask, copyURL wont work, but open in browser will.
Comment 1 Thomas Ehrnhoefer CLA 2011-07-29 13:08:32 EDT 
Created attachment 200610 [details]
changed file

Suggested changes.
Sorry Steffen, I have no clue how I can actually get you a patch with git
Comment 2 Thomas Ehrnhoefer CLA 2011-07-29 13:08:38 EDT 
Created attachment 200611 [details]
mylyn/context/zip
Comment 3 Steffen Pingel CLA 2011-08-11 09:55:33 EDT 
Thomas, to create a patch, please commit locally and then follow these steps: http://wiki.eclipse.org/EGit/User_Guide#Creating_Patches
Comment 4 Thomas Ehrnhoefer CLA 2011-08-11 10:21:10 EDT 
Created attachment 201316 [details]
patch v1
Comment 5 Steffen Pingel CLA 2011-08-12 08:40:00 EDT 
This looks good. I am happy to apply if you could make the following changes: rename getTaskUrl() to getUrl(), add an @author tag for yourself and add a test case to CopyDetailsActionTest. Thanks!
Comment 6 Thomas Ehrnhoefer CLA 2011-11-25 14:14:27 EST 
Created attachment 207553 [details]
patch v2
Comment 7 Thomas Ehrnhoefer CLA 2011-11-25 14:14:30 EST 
Created attachment 207554 [details]
mylyn/context/zip
Comment 8 Steffen Pingel CLA 2011-11-27 14:01:59 EST 
Thanks! I have applied the patch.