Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 353344 - Organize manifest tool should not be available if custom=true is set on build.properties
Summary: Organize manifest tool should not be available if custom=true is set on build...
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.8 M3   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 361989
  Show dependency tree
 
Reported: 2011-07-28 12:30 EDT by Curtis Windatt CLA
Modified: 2011-10-25 14:29 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2011-07-28 12:30:13 EDT 
1) Create a plug-in project with at least one internal package
2) Check that the manifest exports the package as x-internal
3) Delete contents of build.properties and replace with custom = true
4) Run the organize manifest wizard
Result:
The exported package is removed

When a custom build setup is used, the build.properties may not contain the required data to organize the manifest.  The organize manifest tool may make the existing manifest incorrect.

When using a custom build setup, the organize manifest wizard/tool should not be available, or it should warn the user that the changes may not be correct.
Comment 1 Curtis Windatt CLA 2011-07-28 14:40:19 EDT 
In addition to the context menu of the project, the tool is available as a link on the overview page of the manifest editor.
Comment 2 Curtis Windatt CLA 2011-09-30 14:21:51 EDT 
Fixed in master.  Decided to go with a warning in the wizard over blocking the wizard from opening.  If the command disappeared from the menu, the user would have no idea why.

http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=9603ce0f6614316ac5afabe8a1e3f250d8c11ddf
Comment 3 Curtis Windatt CLA 2011-10-25 14:28:47 EDT 
Filed bug 361989 for duplicate errors in the warning

The warning show up when it should, marking as VERIFIED in I20111021-1625