Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 353326 - compile error due to unused import in RegisterManager
Summary: compile error due to unused import in RegisterManager
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug (show other bugs)
Version: 7.0.2   Edit
Hardware: All All
: P3 blocker (vote)
Target Milestone: 7.0.3   Edit
Assignee: Chris Recoskie CLA
QA Contact: Ken Ryall CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-28 10:14 EDT by Chris Recoskie CLA
Modified: 2011-07-29 12:38 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Recoskie CLA 2011-07-28 10:14:37 EDT 
Description	Resource	Path	Location	Type
The import java.util.Map.Entry is never used	RegisterManager.java	/org.eclipse.cdt.debug.mi.core/cdi/org/eclipse/cdt/debug/mi/core/cdi	line 22	Java Problem
Comment 1 Chris Recoskie CLA 2011-07-28 10:15:28 EDT 
I'll fix it shortly... just need to remove the unused import.
Comment 2 CDT Genie CLA 2011-07-28 11:18:17 EDT 
*** cdt git genie on behalf of 353326 ***

    Bug 353326 - compile error due to unused import in RegisterManager

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=286e27f08c475df68fe1f6132a021d31c5dd6863
Comment 3 Chris Recoskie CLA 2011-07-28 12:19:00 EDT 
Fixed on cdt_7_0, cdt_8_0, and HEAD
Comment 4 CDT Genie CLA 2011-07-28 13:49:13 EDT 
*** cdt git genie on behalf of Chris Recoskie ***

    Bug 353326 - compile error due to unused import in RegisterManager

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=0595a48a7fbba73e78a670e36ae82fbafd362ea7
Comment 5 CDT Genie CLA 2011-07-28 13:49:15 EDT 
*** cdt git genie on behalf of Chris Recoskie ***

    Bug 353326 - compile error due to unused import in RegisterManager

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=87d2a15da8cb13e1ae4fc109763d70fd174b49c4
Comment 6 Anton Leherbauer CLA 2011-07-29 03:50:20 EDT 
I did not see a compile error previously, but I do see one now:

Description	Resource	Path	Location	Type
The type Entry is not visible	RegisterManager.java	/org.eclipse.cdt.debug.mi.core/cdi/org/eclipse/cdt/debug/mi/core/cdi	line 72	Java Problem

Also, if you increment the bundle version in MANIFEST.MF you need to change it in pom.xml as well.

See also https://hudson.eclipse.org/hudson/job/cdt-nightly/773/

I already fixed the issues on master and cdt_8_0.
Comment 7 Chris Recoskie CLA 2011-07-29 10:14:29 EDT 
(In reply to comment #6)
> I did not see a compile error previously, but I do see one now:
> Description    Resource    Path    Location    Type
> The type Entry is not visible    RegisterManager.java   
> /org.eclipse.cdt.debug.mi.core/cdi/org/eclipse/cdt/debug/mi/core/cdi    line 72
>    Java Problem
> Also, if you increment the bundle version in MANIFEST.MF you need to change it
> in pom.xml as well.
> See also https://hudson.eclipse.org/hudson/job/cdt-nightly/773/
> I already fixed the issues on master and cdt_8_0.

So you reverted the commit?

I'll revert it on cdt_7_0
Comment 8 Chris Recoskie CLA 2011-07-29 11:44:49 EDT 
Actually, since Toni's fix will fix it for both scenarios, I'm using that, and moving this from INVALID to FIXED.

I put Toni's fix on cdt_7_0.  He already put it on cdt_8_0 and master
Comment 9 CDT Genie CLA 2011-07-29 12:23:03 EDT 
*** cdt git genie on behalf of Chris Recoskie ***

    Bug 353326 - compile error due to unused import in RegisterManager

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=d628fd64ea6c4571bb262e710c2573fe4f821eb4
Comment 10 CDT Genie CLA 2011-07-29 12:38:06 EDT 
*** cdt git genie on behalf of Chris Recoskie ***

    Bug 353326 - compile error due to unused import in RegisterManager

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=21fe2d0dadac52987b35d48aec87e321099cb442