Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 353291 - [Markers] QuickFixPage has broken sorter
Summary: [Markers] QuickFixPage has broken sorter
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.8 M3   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-28 04:53 EDT by Dani Megert CLA
Modified: 2011-10-26 04:20 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2011-07-28 04:53:44 EDT 
3.7.

The sorter in QuickFixPage does not use the parameter 'e2':
	public int compare(Viewer viewer, Object e1, Object e2) {
		return ((IMarkerResolution) e1).getLabel().compareTo(
			((IMarkerResolution)e1).getLabel());
	}
Comment 1 Dani Megert CLA 2011-09-26 11:40:50 EDT 
R3_development: commit e5fb18a2c8bebc09db8296859f3283c7d7a25a2a

I cherry picked it in my R4_dev workspace but so far I get an error when trying to push. Grrr!

Remy, any idea?
Comment 2 Remy Suen CLA 2011-09-26 11:47:32 EDT 
(In reply to comment #1)
> I cherry picked it in my R4_dev workspace but so far I get an error when trying
> to push. Grrr!
> 
> Remy, any idea?

Have you fetched? Which error are you getting? Is it the same one as bug 358100?
Comment 3 Dani Megert CLA 2011-09-26 11:55:21 EDT 
> I cherry picked it in my R4_dev workspace but so far I get an error when trying
> to push. Grrr!
Restart fixed the issue.

R4_development commit: 20fc04ce1be3b26ce99a8e0b515e1029c81a2b70
Comment 4 Dani Megert CLA 2011-09-26 11:57:03 EDT 
> Have you fetched?
Yes, tried several times and also pulled.

> Which error are you getting? Is it the same one as bug
> 358100?
Yes.

After exit and restart all went well. Ugly beast!
Comment 5 Dani Megert CLA 2011-10-26 04:20:23 EDT 
Verified through code inspection.