Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 35328 - [MenuMgmt] Please make action xml style="pulldown" an API
Summary: [MenuMgmt] Please make action xml style="pulldown" an API
Status: RESOLVED DUPLICATE of bug 12757
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Douglas Pollock CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 29709
Blocks:
  Show dependency tree
 
Reported: 2003-03-19 17:51 EST by Richard Kulp CLA
Modified: 2011-07-28 10:58 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Kulp CLA 2003-03-19 17:51:40 EST
I've been told in the newsgroup that though ObjectActionContribution supports
style="pulldown", the latest documentation for 2.1 doesn't list "pulldown" as a
supported API value. I don't have the latest docs to verify this.

It works well and we need this because we need to add a dynamic menu to the
object popup menu. We can't predefine what will be on the submenu until we know
what was selected. This style is the only way we can add a dynamic menu.

We had done it in 2.0.x by making our ObjectActionDelegate into a MenuCreator
and setting that MenuCreator into the ActionDelegate, but in 2.1 this was broken
because Action couldn't be changed to a drop-down if it wasn't created as a
dropdown. This broke us, so we found the stle="pulldown" which is exactly what
we needed.

Thanks,
Rich
Comment 1 Richard Kulp CLA 2003-03-19 17:53:27 EST
To be clear, this Object contribution needs tp be contributed through
plugin.xml, that is why we couldn't create it as a pulldown through code. That
is why we want to use the style="pulldown" from the plugin.xml.
Comment 2 Nick Edgar CLA 2003-03-21 12:26:01 EST
We never intended to support the contribution of dynamic submenus, since that 
requires activating the contributing plugin.

However, the breaking change to your old way of doing things was unintentional.

This situation is similar to our desire to allow items to be dynamically 
added/removed in action sets, but to have the Workbench remember the items, so 
that plugins do not need to be eagerly activated.

It would help to know more details of what you're trying to do here.
What kind of submenu and items are you trying to present?
Comment 3 Richard Kulp CLA 2003-03-21 12:47:21 EST
This basically having to do with the same dynamic menu that I am talking about
in this bug: 

http://bugs.eclipse.org/bugs/show_bug.cgi?id=11114

So you can look there to see all of the details. They go hand-in-hand. That bug
report was about isDynamic() now returning false for our pulldowns, while this
one is about not being able to create a pulldown at all anymore without using
style="pulldown", but they are both about the same topic, having dynamic object
contribution menus.

We are using the <visibility>/<filter> stuff to make sure our contributions
aren't even activated until absolutely necessary, so eager dynamic menus
wouldn't occur.

Thanks, Rich
Comment 4 Simon Arsenault CLA 2003-03-21 15:36:19 EST
To be looked at in 2.2 stream
Comment 5 Douglas Pollock CLA 2004-10-29 10:48:45 EDT

*** This bug has been marked as a duplicate of 12757 ***