Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 353275 - CDOTransaction/CDOView getResourceNode does not return null
Summary: CDOTransaction/CDOView getResourceNode does not return null
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.core (show other bugs)
Version: 4.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Eike Stepper CLA
QA Contact: Eike Stepper CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-28 00:09 EDT by Eike Stepper CLA
Modified: 2012-09-21 06:50 EDT (History)
0 users

See Also:

Attachments
Fix (2.86 KB, patch)
2011-07-28 00:11 EDT, Eike Stepper CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eike Stepper CLA 2011-07-28 00:09:02 EDT 
Cloned from: 353249: CDOTransaction/CDOView getResourceNode does not return null
https://bugs.eclipse.org/bugs/show_bug.cgi?id=353249

Build Identifier:  I20110613-1736

+ In the Javadocs for getResourceNode it says "Returns the resource node with the given path, or null if no such resource node exists."
+ When I try to retrieve a resource node that doesn't exist I will get an exception "org.eclipse.emf.cdo.common.util.CDOException: No top level ResourceNode with the name xxxx"
+ Javadocs should be updated or the implementation should modified to correspond to the documentation, in this case my personal opinion is that it makes sense to return null if the node doesn't exist.

Reproducible: Always

Steps to Reproduce:
1. Run the unit test, expected result should be for the test to pass, instead it will throw an exception.
Comment 1 Eike Stepper CLA 2011-07-28 00:11:11 EDT 
Created attachment 200488 [details]
Fix
Comment 2 Eike Stepper CLA 2011-07-28 00:26:59 EDT 
Committed revision 8835:
- branches/4.0-maintenance/plugins/org.eclipse.emf.cdo
- branches/4.0-maintenance/plugins/org.eclipse.emf.cdo.tests
Comment 3 Eike Stepper CLA 2011-07-28 00:27:21 EDT 
Resolved.
Comment 4 Eike Stepper CLA 2012-09-21 06:50:25 EDT 
Closing.