Description Richard Kulp 2003-03-19 17:26:14 EST

If you have MenuItems of RadioButton style, the MenuItems automatically control
the selection behaviour. The problem is the
ActionContributionItem.handleWidgetSelection method overrides this behaviour and
is wrong. This can be seen when you have two RadioButton type MenuItems and you
select the item that is already selected. MenuItem will properly RESELECT the
item, but handleWidgetSelection will simply take the current selection state out
of the Action (ignoring the state in the MenuItem) and negate it. But since the
current state in the Action is true, it sets it to false. This then leaves no
menuitems selected, which is wrong.

For MenuItems, the checkbox and radiostyle are automatically handled by the
MenuItem (though they were handled incorrectly in 2.0.x) and the
ActionContributor should use the current value of the MenuItem selection. This
can also be called for Button, but it looks like Button also automatically
handles the style too. But that needs to be verified.

Thanks, Rich Kulp