Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 353238 - [1.7] update unusedTypeArgs option description for the batch compiler
Summary: [1.7] update unusedTypeArgs option description for the batch compiler
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.7.1   Edit
Assignee: Ayushman Jain CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-27 13:47 EDT by Olivier Thomann CLA
Modified: 2011-09-14 02:01 EDT (History)
2 users (show)

See Also:
jarthana: review+


Attachments
proposed fix (14.01 KB, patch)
2011-08-05 07:04 EDT, Ayushman Jain CLA
no flags Details | Diff
proposed fix v.1.1 (13.99 KB, patch)
2011-08-08 05:04 EDT, Ayushman Jain CLA
no flags Details | Diff
Proposed fix (783 bytes, patch)
2011-08-25 09:04 EDT, Olivier Thomann CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2011-07-27 13:47:08 EDT
This option is now also used to report redundant type arguments specification with the diamond case. This should be updated in the help displayed for warning options as well as the batch compiler documentation.
Comment 1 Srikanth Sankaran CLA 2011-08-04 00:31:09 EDT
Ayush, can you look into this in Olivier's absence ? Thanks.
Comment 2 Ayushman Jain CLA 2011-08-05 07:04:29 EDT
Created attachment 200970 [details]
proposed fix

Updated the jdt.doc.user for the batch compiler option "unusedTypeArgs" and also added a new test in BatchCompilerTests to test this option. Also updated jdt.doc.isv project to add all new option APIs added for java 7 work - including redundant specification of type arguments and all the new formatter alignment and spacing options.
Comment 3 Srikanth Sankaran CLA 2011-08-05 07:11:22 EDT
Satyam, could you please give this patch a once over ?
Comment 4 Srikanth Sankaran CLA 2011-08-05 07:11:53 EDT
(In reply to comment #3)
> Satyam, could you please give this patch a once over ?

I meant you Jay - thanks.
Comment 5 Jay Arthanareeswaran CLA 2011-08-08 04:48:14 EDT
Ayush, is there a reason why the message is different in the batch compiler documentation?
Comment 6 Ayushman Jain CLA 2011-08-08 05:01:02 EDT
(In reply to comment #5)
> Ayush, is there a reason why the message is different in the batch compiler
> documentation?

This is an oversight. I had shortened the message because it was exceeding the 80 character limit, but forgot to change that in the documentation. Thanks. Will correct it.
Comment 7 Ayushman Jain CLA 2011-08-08 05:04:52 EDT
Created attachment 201059 [details]
proposed fix v.1.1

Corrected above mistake
Comment 8 Jay Arthanareeswaran CLA 2011-08-08 05:47:00 EDT
Changes look good.

Just for the records, the patch includes documentation changes for the formatter options for try with resources and multi-catch as well.
Comment 9 Ayushman Jain CLA 2011-08-08 05:53:12 EDT
Released in HEAD for 3.8M2 and in R_3_7_maintenance for 3.7.1
Comment 10 Srikanth Sankaran CLA 2011-08-25 05:14:55 EDT
Verified for 3.7.1 RC2 using Build id: M20110824-0800
Comment 11 Srikanth Sankaran CLA 2011-08-25 06:02:07 EDT
Actually, I am able to verify the text of the new warning message
in the batch compiler.

But if I look at F1 + batch compiler page, I don't see the new text
"unused type arguments for method and constructor" but see only
the old text "unused type arguments for method".

Did I miss something ?
Comment 12 Olivier Thomann CLA 2011-08-25 09:04:45 EDT
Created attachment 202148 [details]
Proposed fix

This is a doc change.
Comment 13 Olivier Thomann CLA 2011-08-25 09:07:20 EDT
Released into the doc for next build 3.7.1.
Comment 14 Olivier Thomann CLA 2011-08-25 09:13:30 EDT
Released as FIXED as the doc bundle has been updated.
Comment 15 Jay Arthanareeswaran CLA 2011-09-05 07:23:00 EDT
Verified for 3.7.1 with build M20110831-1030.

I still don't see the help documents updated with the change as observed in comment # 11. I suppose the documentation changes are not part of the M builds yet, are they?
Comment 16 Srikanth Sankaran CLA 2011-09-14 02:01:54 EDT
Verified for 3.8M2 using build id  I20110912-0800.

(In reply to comment #15)
> Verified for 3.7.1 with build M20110831-1030.
> 
> I still don't see the help documents updated with the change as observed in
> comment # 11. I suppose the documentation changes are not part of the M builds
> yet, are they?

Shows up properly with the M2 build.