Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 353170 - Selection of specific resources to commit fails if selected resource is not already "added"
Summary: Selection of specific resources to commit fails if selected resource is not a...
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-27 02:11 EDT by Rob Stryker CLA
Modified: 2012-08-30 08:48 EDT (History)
2 users (show)

See Also:


Attachments
Ensure selected IFile objects are force-selected (4.35 KB, patch)
2011-07-27 02:40 EDT, Rob Stryker CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Stryker CLA 2011-07-27 02:11:31 EDT
In a project that is fully committed, I make two changes:
  1) Change index.html
  2) Add a new file blah.txt

I then select both index.html and blah.txt, right-click, and select commit. In the ensuing dialog, *ONLY* index.html is selected. Blah.txt is ignored because it has not been previously added to the repository. 

The offending code is in CommitDialog.createDialogArea when deciding which of the pre-selection candidates are acceptable. A conscious decision was made to ignore those that are not added already (such as .project, etc) when selecting a folder, however the use-case where specifically-selected files are not pre-selected. 

     && item.status != Status.UNTRACKED && item.status != Status.ASSUME_UNCHANGED)

Patch to be attached to force IFile selections to be pre-selected whether they are already added to the repo or not.
Comment 1 Rob Stryker CLA 2011-07-27 02:16:34 EDT
Updating version info.  I am using version     Eclipse EGit - Source	1.0.0.201106090707-r	org.eclipse.egit.source.feature.group	Eclipse EGit

I would also like to note that your target versions are in complete disarray here in bugzilla and in discernable order ;) 

0.6.0-M1
0.6.0-M2
0.6.0-M3
0.7.0
0.8.0
1.0.0
0.9.0
0.9.0-M3
0.9.0-M2
0.9.0-M1
0.10.0-M1
0.10.0-M2
0.10.0-M3
0.10.0-M1
etc etc etc
Comment 2 Rob Stryker CLA 2011-07-27 02:40:22 EDT
Created attachment 200416 [details]
Ensure selected IFile objects are force-selected
Comment 3 Rob Stryker CLA 2011-10-31 01:23:32 EDT
Howdy all:

Is there anything I can do to have this bug / patch investigated? It's been sitting here for months. Anything at all? Do I just assign it to someone? To who? Should I set a target milestone? I'm not sure if I know enough about the product to decide the proper milestone for release.
Comment 4 Remy Suen CLA 2011-10-31 06:59:53 EDT
(In reply to comment #3)
> Is there anything I can do to have this bug / patch investigated?

It's probably better to get your change set pushed to Gerrit.
Comment 5 Andre Dietisheim CLA 2012-08-30 08:48:01 EDT
this patch is now obsolete. The current commit dialog behaves in the way this issue suggests. You'd have to enable it in the preferences though:

Check the checkbox at preferences->git->commit dialog->"Include selected untracked files".