Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 353127 - Release fails when non-git map entries encountered
Summary: Release fails when non-git map entries encountered
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 0.12   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.12   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-26 11:08 EDT by John Arthorne CLA
Modified: 2011-08-18 11:46 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2011-07-26 11:08:26 EDT 
Version 0.12

MapContentDocument.java line 60 creates a Status object, but passes an empty string as the plugin id. This is illegal, and results in a runtime exception on this line. The cause of the original error is lost in the process.
Comment 1 John Arthorne CLA 2011-07-26 11:20:26 EDT 
Attempting to push a fix to gerrit, but I get an error "[remote rejected] no common ancestry". Not sure what this means because I pulled immediately prior to creating the fix.
Comment 2 John Arthorne CLA 2011-07-26 11:24:12 EDT 
Here is the error stack:

java.lang.IllegalArgumentException: 
	at org.eclipse.core.runtime.Assert.isLegal(Assert.java:63)
	at org.eclipse.core.runtime.Assert.isLegal(Assert.java:47)
	at org.eclipse.core.runtime.Status.setPlugin(Status.java:237)
	at org.eclipse.core.runtime.Status.<init>(Status.java:129)
	at org.eclipse.egit.internal.relengtools.MapContentDocument.updateTag(MapContentDocument.java:60)
	at org.eclipse.egit.internal.relengtools.MapFileCompareEditorInput.constructDocuments(MapFileCompareEditorInput.java:173)
	at org.eclipse.egit.internal.relengtools.MapFileCompareEditorInput.updateInput(MapFileCompareEditorInput.java:84)
	at org.eclipse.egit.internal.relengtools.MapFileComparePage.setVisible(MapFileComparePage.java:47)
Comment 3 John Arthorne CLA 2011-07-26 11:53:02 EDT 
I have pushed a fix to gerrit:

http://egit.eclipse.org/r/#change,3920

All the other changes appear to be formatting and automatic code cleanup settings that were already configured for that project. I didn't explicitly do any other cleanup or formatting of the code. I just made the one line change.
Comment 4 John Arthorne CLA 2011-07-26 12:05:52 EDT 
Actually that isn't the right fix. It fixes the error handling but not the underlying problem. Another patch coming...
Comment 5 John Arthorne CLA 2011-07-26 13:08:03 EDT 
Try this one:

http://egit.eclipse.org/r/#change,3921
Comment 6 John Arthorne CLA 2011-08-18 11:45:48 EDT 
My fix was released. See:

http://egit.eclipse.org/r/#change,3937