Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 353120 - Git status is broken if user.name and user.email are not in the repo configuration
Summary: Git status is broken if user.name and user.email are not in the repo configur...
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Git (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 major (vote)
Target Milestone: 0.3 M1   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard: gsoc2011
Keywords:
Depends on: 350422
Blocks:
  Show dependency tree
 
Reported: 2011-07-26 10:35 EDT by Szymon Brandys CLA
Modified: 2012-11-15 11:26 EST (History)
2 users (show)

See Also:

Attachments
Broken Git Status page (35.75 KB, image/png)
2011-07-26 10:36 EDT, Szymon Brandys CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Brandys CLA 2011-07-26 10:35:09 EDT 
For repos without user.name and user.email in the configuration Git Status page does not work. The workaround is to add these props to the configuration.
Comment 1 Szymon Brandys CLA 2011-07-26 10:36:15 EDT 
Created attachment 200362 [details]
Broken Git Status page
Comment 2 Piotr Janik CLA 2011-07-26 13:34:20 EDT 
https://github.com/pjanik/orion.client/tree/bug353120
I wrote all this code and have the rights to contribute it to Eclipse under the
eclipse.org web site terms of use.
Comment 3 Tomasz Zarna CLA 2011-07-28 07:29:29 EDT 
Can you extract these lines into a function, to reduce code duplication?

			that._userEmail = configEntry.Value;
			that._processCloneInfo();
			that._processStatus();
			
Other then that, looks good.
Comment 4 Piotr Janik CLA 2011-07-28 07:38:02 EDT 
Updated, available at github.