Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 353109 - The EMFCompareEObjectCopier should take DiffResourceSets into account
Summary: The EMFCompareEObjectCopier should take DiffResourceSets into account
Status: CLOSED FIXED
Alias: None
Product: EMFCompare
Classification: Modeling
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 critical (vote)
Target Milestone: ---   Edit
Assignee: EMF Compare CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-26 09:45 EDT by Laurent Goubet CLA
Modified: 2011-07-26 10:26 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Goubet CLA 2011-07-26 09:45:12 EDT
Currently, the EMF Compare copier only takes DiffModels into account. This is a legacy from the time EMF Compare did not consider whole resource sets for the comparison; and causes random bugs due to the order in which differences are merged.

For example, if a given comparison involves three resources, we have one DiffResourceSet containing three DiffModels. Merging a difference from the first of these DiffModels creates a Copier for it. If I then merge a difference from the second DiffModel, the Copier is reset (!) and a new one is instantiated for the second DiffModel. This implies that all information from previously merged differences are lost.

This also implies that the Copier won't be able to find diff information if they are located in other DiffModels; preventing most of its logic to be set in motion.
Comment 1 Laurent Goubet CLA 2011-07-26 10:26:59 EDT
This has now been fixed on master.