Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 353049 - [metatype] Review API extensions to Metatype.
Summary: [metatype] Review API extensions to Metatype.
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Compendium (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: Juno M5   Edit
Assignee: Thomas Watson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 349711
Blocks:
  Show dependency tree
 
Reported: 2011-07-25 17:23 EDT by John Ross CLA
Modified: 2012-01-23 12:45 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Ross CLA 2011-07-25 17:23:20 EDT 
See bug 349711 for a detailed description of the API and other related changes.
Comment 1 Thomas Watson CLA 2011-10-21 08:49:58 EDT 
Assigning to myself to make sure I review it in M4.
Comment 2 John Ross CLA 2011-11-18 12:36:21 EST 
We may have an issue. See https://www.osgi.org/members/bugzilla/show_bug.cgi?id=2196.

The updates from bug 349711 are currently causing us to fail the CT. Not sure how I missed it before. I was probably executing the CT against a previous version without realizing it.

If the test referenced in 2196 is valid, we'll need to change the return types back from Equinox* so that the MetaTypeProviderTracker can return just ObjectClassDefinition. We can then add new methods to retrieve the Equinox* types or clients will need to cast.
Comment 3 John Ross CLA 2011-11-18 12:38:49 EST 
On an unrelated note, I still need to complete the Javadoc for this.
Comment 4 John Ross CLA 2011-11-22 11:10:46 EST 
(In reply to comment #3)
> On an unrelated note, I still need to complete the Javadoc for this.

Javadoc pushed to master.

http://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=54a28d51979513dda2948dfd597babfb14e9dc8f
Comment 5 Thomas Watson CLA 2011-12-06 15:28:54 EST 
kicking the can to M5, sorry.
Comment 6 John Ross CLA 2011-12-06 15:32:07 EST 
(In reply to comment #2)
> We may have an issue. See
> https://www.osgi.org/members/bugzilla/show_bug.cgi?id=2196.
> The updates from bug 349711 are currently causing us to fail the CT. Not sure
> how I missed it before. I was probably executing the CT against a previous
> version without realizing it.
> If the test referenced in 2196 is valid, we'll need to change the return types
> back from Equinox* so that the MetaTypeProviderTracker can return just
> ObjectClassDefinition. We can then add new methods to retrieve the Equinox*
> types or clients will need to cast.

I should note that it was decided to remove that test from the CT, and there is no longer an issue. No changes to the API are required.
Comment 7 Thomas Watson CLA 2012-01-23 12:45:23 EST 
I reviewed the API and they look good to me.  Thanks John.