Community
Participate
Working Groups
Build Identifier: 3.7.0 In 3.6, a menuContribution of a command whose commandId was "org.eclipse.ui.file.import" would show up in the menu bar as an option whose text was taken from the command's label (for example, "My Command...") Since 3.7, our menu command now reads "My Command", which is the name of the WIZARD (as bound using the command parameter importWizardId). As you can imagine, we can't change the wizard's name to have the ellipsis, but we'd like them back in the menu text. Reproducible: Always Steps to Reproduce: See details
Could you provide code that reproduces the problem?
Created attachment 200728 [details] source project demonstrating issue
Attached, a project that contributes an import wizard and a menu contribution to the File menu. Launched against and in Eclipse 3.6, you see the menu contribution's label and icon Launched against and in Eclipse 3.7, you see the wizard's label (and the import icon coming from somewhere) As I stated, this regression I believe is important, because this use case shows how you cannot thus end up with a menu contribution to a wizard with a label applicable to a menu entry ("..." to signify a dialog will appear), but having the proper label (no "...") in the wizard selection dialog!
Maybe caused by fix for bug 327690?
any possibility to schedule this for 3.7.2? is there a possible workaround to get the contribution to appear with a label we want in the menu bar? (even if it's a programmatic "hack" at plug-in start)
I can get this fixed for 3.8, but won't be able to look at it in time for 3.7.2. If someone contributes a patch, we can consider it for 3.7.2, though. PW
We can live with just waiting for 3.8 (it's cosmetic, just has us miss a "..." we used to have in the menu label)
I've released a fix for 3.8 and 4.2 PW
(In reply to comment #8) > I've released a fix for 3.8 and 4.2 > > PW The fix "works" but in general strings should not be concatenated in the code. There might be languages which use a different terminology than "...".
This is low risk enough that we can fix it correctly for tomorrow. PW
Released to 4.2 and 3.8 PW
Verified through code review.
The bug seems to be resurrected in Eclipse 4.3. The label and the icon of the contribution item in a view menu or view toolbar will be overwritten by the assigned (newWizardId, importWizardId, exportWizardId) wizard. This affects not only the default label of the command but also the label and icon defined in the view menu contribution (if there is any).
To my previous comment. The application is an Eclipse 4.3 RCP application using the compatibiliy layer.
(In reply to Uwe Peuker from comment #13) > The bug seems to be resurrected in Eclipse 4.3. > > The label and the icon of the contribution item in a view menu or view > toolbar will be overwritten by the assigned (newWizardId, importWizardId, > exportWizardId) wizard. > > This affects not only the default label of the command but also the label > and icon defined in the view menu contribution (if there is any). I suggest you open a new bug with exact steps/example.
(In reply to Dani Megert from comment #15) > I suggest you open a new bug with exact steps/example. Done: https://bugs.eclipse.org/bugs/show_bug.cgi?id=416461
