Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 352999 - ExpireTest running too long
Summary: ExpireTest running too long
Status: CLOSED FIXED
Alias: None
Product: Jetty
Classification: RT
Component: client (show other bugs)
Version: 7.4.2   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 enhancement (vote)
Target Milestone: 7.5.x   Edit
Assignee: Jan Bartel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-25 08:30 EDT by Thomas Becker CLA
Modified: 2011-08-02 09:05 EDT (History)
2 users (show)

See Also:

Attachments
proposed patch (1.22 KB, patch)
2011-07-25 08:32 EDT, Thomas Becker CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Becker CLA 2011-07-25 08:30:35 EDT 
Build Identifier: 

This test sends 200 client requests to the server. To verify that the onExpire method is being called the only handler is just waiting for 2000ms and a countDownlatch is counted down in the onExpire method.

After sending each requests the test waits for 50ms. To me there's no obvious reason to wait, so I removed the Thread.sleep call. 

Reduced the testrun from >10s to <1s.

Reproducible: Always
Comment 1 Thomas Becker CLA 2011-07-25 08:32:46 EDT 
Created attachment 200274 [details]
proposed patch
Comment 2 Jesse McConnell CLA 2011-08-02 09:05:02 EDT 
- Log -----------------------------------------------------------------
commit cd0dd3e8ffd34d80b4d614c8d05c1687eae7d5bd
Author: Jesse McConnell <jesse.mcconnell@gmail.com>
Date:   Tue Aug 2 08:04:18 2011 -0500

   [Bug 352999] test performance patch applied to jetty-client, thanks Thomas

-----------------------------------------------------------------------

Summary of changes:
 VERSION.txt                                        |    1 +
 .../java/org/eclipse/jetty/client/ExpireTest.java  |    2 --
 2 files changed, 1 insertions(+), 2 deletions(-)