Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 352945 - [ast] Regenerate Switch for SR1
Summary: [ast] Regenerate Switch for SR1
Status: CLOSED FIXED
Alias: None
Product: OCL
Classification: Modeling
Component: Core (show other bugs)
Version: 3.1.0   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: SR1   Edit
Assignee: OCL Inbox CLA
QA Contact: Ed Willink CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-24 07:45 EDT by Ed Willink CLA
Modified: 2013-05-20 11:36 EDT (History)
1 user (show)

See Also:

Attachments
Regeneration (1.78 MB, patch)
2011-08-21 15:05 EDT, Ed Willink CLA 		no flags Details | Diff
SR1 patch eliminating text formatting changes (25.97 KB, patch)
2011-08-21 15:44 EDT, Ed Willink CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Willink CLA 2011-07-24 07:45:32 EDT 
Indigo EMF introduced an abstract Switch class for all switches. Not all Indigo models picked this up. Regenerate all models for SR1.
Comment 1 Axel Uhl CLA 2011-07-24 12:07:17 EDT 
The patch for 349117 already re-generated some models. Should we create a dependency between the bugs?
Comment 2 Ed Willink CLA 2011-08-21 15:05:20 EDT 
Created attachment 201877 [details]
Regeneration

The OCLCodeFormatter is now in the project preferences.

Organise importants and seemingly some slight formatting rule chnage gives many trivial changes.

Changes also pushed upstream as bug/352945.
Comment 3 Ed Willink CLA 2011-08-21 15:44:50 EDT 
Created attachment 201880 [details]
SR1 patch eliminating text formatting changes

Patch for SR1, also pushed upstream as bug/352945sr1
Comment 4 Ed Willink CLA 2011-08-21 15:48:34 EDT 
Please review attachment 201877 [details] for M2.

Please review attachment 201880 [details] for SR1.
Comment 5 Axel Uhl CLA 2011-08-23 04:51:18 EDT 
Reviewing. As far as I can see, all changes under org.eclipse.ocl.ecore.edit are really only whitespace changes and the project preferences which now contain the formatter. This part looks ok.

EcorePackage and EcoreAdapterFactory seem to have streamlined imports now which is good.

EcoreSwitch is where the significant changed based on the re-generation show up, particularly the new "extends Switch<T>" which is the core reason for re-generating. The changes are all implied by the generator and look ok.

To org.eclipse.ocl.edit: again the formatter changes and accordingly all the many whitespace changes. I did some random reviews in some of the classes and they all appear to be whitespace-only changes (haven't found a good diff tool to suppress those; -w doesn't seem to do the job...). Same for org.eclipse.ocl.uml.edit.

In UMLAdapterFactory the imports are cleaned up. UMLSwitch has the above to-be-expected changes according to re-generation and a cleaned-up imports list. Ok. UMLValidator has the cleaned imports and whitespace-only changed. Also ok.

org.eclipse.ocl.cst.util.CSTSwitch has the expected changes with the new Switch<T> base class factoring. The org.eclipse.ocl.expressions changes all look like whitespace-only.

ExpressionsSwitch: see above for the other Switch classes.

org.eclipse.ocl.types.impl only has whitespace changes.

TypesSwitch: see above for the other Switch classes.

UtilitiesAdapterFactory has cleaned-up imports. Ok.

UtilitiesSwitch: see above for the other Switch classes.

+1
Comment 6 Ed Willink CLA 2011-08-23 13:12:55 EDT 
Pushed to maintenance/R3_1 for SR1 RC2.

Pushed to master for M2.
Comment 7 Ed Willink CLA 2013-05-20 11:36:50 EDT 
CLOSED after a year in the RESOLVED state.