Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 352893 - Compare with enumeration causes a stack trace in the javascript generator
Summary: Compare with enumeration causes a stack trace in the javascript generator
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-22 13:16 EDT by Joseph Vincens CLA
Modified: 2017-02-23 14:14 EST (History)
1 user (show)

See Also:

Attachments
Library that exhibits enumeration problems (524 bytes, application/octet-stream)
2011-08-02 09:03 EDT, Joseph Vincens CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Vincens CLA 2011-07-22 13:16:15 EDT 
The following egl expression produces the stack trace below:
		xx Encoding = Encoding.XML;
		if(xx == Encoding.XML)
			writestdout("  ");
		end


Caused by: org.eclipse.edt.mof.egl.NoSuchFunctionError
	at org.eclipse.edt.mof.egl.impl.BinaryExpressionImpl.resolveOperation(BinaryExpressionImpl.java:61)
	at org.eclipse.edt.mof.egl.impl.MultiOperandExpressionImpl.getOperation(MultiOperandExpressionImpl.java:43)
Comment 1 Joseph Vincens CLA 2011-08-02 09:03:07 EDT 
Created attachment 200708 [details]
Library that exhibits enumeration problems
Comment 2 Joseph Vincens CLA 2011-08-02 09:13:07 EDT 
Can't pass an enumeration as a function parameter. 
IRUtils.makeExprCompatibleToType does 
if (exprType.equals(type) || exprType.getClassifier().equals(type))

exprType.equals(type) calls Enumeration.equals which does this == eglType, which fails because they are not the same object even though this and eglType are the same type Instance of: org.eclipse.edt.mof.egl.Enumeration - eglx._service.Encoding.
Comment 3 Paul Harmon CLA 2011-09-19 12:27:35 EDT 
There have been a few improvements with locating the operations when dealing with enums, as well as changes to the makeCompat routine. This seems to be working ok now. The only strange thing I see is that there is a couple of boxing operations happening in the generated java:

		if ((EglAny.ezeBox(xx) == EglAny.ezeBox(Encoding.XML))) {
		}


These do not appear to cause any problems though.
Comment 4 Joseph Vincens CLA 2011-10-03 08:56:19 EDT 
verified