Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 352881 - Make create operation streamable
Summary: Make create operation streamable
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.5   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 enhancement (vote)
Target Milestone: 1.5 M1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 311355
  Show dependency tree
 
Reported: 2011-07-22 11:17 EDT by Holger Staudacher CLA
Modified: 2011-08-05 10:09 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Staudacher CLA 2011-07-22 11:17:25 EDT 
Currently the new method on the IClientObject creates a "create" operation. The create operation has a properties map. 

When you want to pass properties you have to create a map on the server side and pass this map to the IClientObject#new method. It would be much better to have something like this:

IClientObject obj = ...
obj.new( styles );
obj.setProperty....
obj.setProperty...

From a message point of view this should not create a "create" and "set" operation. This should create just a "create" operation and it should append the properties to the "create" operation's properties map. So, I think we should make the create operation streamable in the ProtocolMessageWriter.
Comment 1 Tim Buschtoens CLA 2011-07-26 05:52:31 EDT 
The client Protocol Processor now processes the "create" operation additinally as an "set" operation, supporting this feature.
Comment 2 Ralf Sternberg CLA 2011-08-05 10:09:10 EDT 
After some consideration, we decided to remove the properties parameter from IClientObject#create(). Properties are now set using IClientObject#setProperty(). Properties are appended to a preceding create operation.
Changes are in CVS HEAD.