Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 352880 - [10.7]Shell toolbar: separator causes toolbar buttons to not show up
Summary: [10.7]Shell toolbar: separator causes toolbar buttons to not show up
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.1   Edit
Hardware: PC Mac OS X
: P3 major (vote)
Target Milestone: 3.8 M2   Edit
Assignee: Silenio Quarti CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-22 11:15 EDT by Thomas Singer CLA
Modified: 2011-08-24 10:33 EDT (History)
4 users (show)

See Also:

Attachments
Sample to reproduce the bug (677 bytes, text/plain)
2011-07-22 11:15 EDT, Thomas Singer CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Singer CLA 2011-07-22 11:15:21 EDT 
Build Identifier: 3.7.0.v3735b

1. launch attached sample on OS X 10.7
=> the toolbar buttons "Hello" and "World" show up
2. uncomment the separator line and relaunch
=> only the toolbar button "Hello" is shown

Reproducible: Always
Comment 1 Thomas Singer CLA 2011-07-22 11:15:54 EDT 
Created attachment 200207 [details]
Sample to reproduce the bug
Comment 2 Lakshmi P Shanmugam CLA 2011-07-25 09:04:22 EDT 
Looks like a bug on OSX 10.7, works fine on my 10.6 system.
Comment 3 Felipe Heidrich CLA 2011-07-28 09:32:01 EDT 
critical means the bug is crash or a hang. That is not the case here.
Changing the priority to major.
Comment 4 Silenio Quarti CLA 2011-08-08 15:58:30 EDT 
According the to Mac Lion release notes:

http://developer.apple.com/library/mac/#releasenotes/Cocoa/AppKit.html

In 10.7, the Customize Toolbar item and the Separator item (with the vertical dots) have been removed from toolbars and customization palettes, and their item identifiers are ignored.

Even though the notes says the identifiers are ignored, it seems cocoa has a bug that causes subsequent items to not show. I released a workaround to avoid creating items with the separator identifier.

Fixed

http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=6e01819248ecead2c3ff7c95ace504bda5ca7a30
Comment 5 Thomas Singer CLA 2011-08-19 04:10:23 EDT 
What exactly your fix does? Doesn't SWT now support toolbar separators any more on OS X 10.7?
Comment 6 Silenio Quarti CLA 2011-08-19 10:07:10 EDT 
Shell toolbar separators are going to be created as simple spacers (no dotted line). I do not see how we can do anything better given that the OS does not support it anymore.
Comment 7 Thomas Singer CLA 2011-08-19 13:34:30 EDT 
(In reply to comment #6)
> Shell toolbar separators are going to be created as simple spacers (no dotted
> line).

That would be fine. I don't know the native Cocoa API - where there spacers *and* separators (dotted line) possible in previous OS X versions? If so, how could they be created with SWT?

(In reply to comment #6)
> I do not see how we can do anything better given that the OS does not
> support it anymore.

No problem from my side - I just need some kind of fixed-size separators (and flexible space) and don't really care whether they look like a dotted line or a larger gap.