Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 352866 - [Gogo] Cannot disable kernel telnet and ssh consoles
Summary: [Gogo] Cannot disable kernel telnet and ssh consoles
Status: CLOSED FIXED
Alias: None
Product: Virgo
Classification: RT
Component: runtime (show other bugs)
Version: 3.0.0.M06   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.0.0.RELEASE   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-22 10:03 EDT by Glyn Normington CLA
Modified: 2011-08-03 04:10 EDT (History)
2 users (show)

See Also:

Attachments
This patch fixes the bug. (3.50 KB, patch)
2011-07-22 11:03 EDT, Borislav Kapukaranov CLA 		no flags Details | Diff
built jar with enhanced fix (122.72 KB, application/octet-stream)
2011-08-02 08:18 EDT, Borislav Kapukaranov CLA 		no flags Details
Sources for the fixed jar (83.36 KB, application/octet-stream)
2011-08-02 08:18 EDT, Borislav Kapukaranov CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Glyn Normington CLA 2011-07-22 10:03:31 EDT 
The enabled=false property works for the user region consoles, but not for the kernel consoles.
Comment 1 Borislav Kapukaranov CLA 2011-07-22 10:24:08 EDT 
Fixed in a local build of the console.supportability bundle.
Lazar will further investigate the cause for this.
Comment 2 Glyn Normington CLA 2011-07-22 10:50:47 EDT 
The mystery is that it ever worked in the user region since both regions publish a org.apache.felix.service.command.CommandProcessor service.
Comment 3 Borislav Kapukaranov CLA 2011-07-22 11:03:27 EDT 
Created attachment 200204 [details]
This patch fixes the bug.

The patch modifies the TelnetCommand and SshCommand classes by introducing an "initialise" method that just saves some configurations and stores the CommandProcessor obejct without starting a telnet or ssh server. This method replaces the old start method.
Comment 4 Glyn Normington CLA 2011-07-22 12:13:09 EDT 
Lazar: please note I would *really* like to avoid making any code changes between Virgo 3.0.0.RC1 and 3.0.0.RELEASE, so I hope you can verify that Borislav's fix is ok for Virgo 3.0.

If there are significant functional problems in his fix which can't wait, then we'll need a RC2 and that might put our schedule at risk.
Comment 5 Glyn Normington CLA 2011-07-25 05:47:07 EDT 
Borislav's patch is in the EBR and will go into 3.0.0.RC1, so setting the target milestone for integrating the exact same fix into Equinox to 3.0.0.RELEASE.
Comment 6 Borislav Kapukaranov CLA 2011-08-02 08:18:01 EDT 
Created attachment 200706 [details]
built jar with enhanced fix

This jar contains an enhanced fix for the problem and should be uploaded to EBR to cover the new fix in RC2.

Source jar will follow.
Comment 7 Borislav Kapukaranov CLA 2011-08-02 08:18:23 EDT 
Created attachment 200707 [details]
Sources for the fixed jar
Comment 8 Glyn Normington CLA 2011-08-02 11:39:35 EDT 
Published 1.0.0.201108021516 in the EBR and pushed to the EBR git repo under commit bb8d1e7e81d3d2d3abe488a5143858085b1f1fde.
Comment 9 Glyn Normington CLA 2011-08-03 04:10:56 EDT 
Upgrade to 1.0.0.201108021516 rippled and pushed.