352832 – CommitIntegrityCheck doesn't treat CDOIDNull as Java NULL value with CDOSetFeatureDelta

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 352832 - CommitIntegrityCheck doesn't treat CDOIDNull as Java NULL value with CDOSetFeatureDelta

Summary: CommitIntegrityCheck doesn't treat CDOIDNull as Java NULL value with CDOSetFe...

Status:	CLOSED FIXED

Alias:	None

Product:	EMF
Classification:	Modeling
Component:	cdo.core (show other bugs)
Version:	4.1
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	---
Assignee:	Egidijus Vaisnora
QA Contact:	Eike Stepper

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-07-22 04:10 EDT by Egidijus Vaisnora
Modified:	2012-09-21 07:18 EDT (History)
CC List:	1 user (show)

See Also:

Flags:	stepper: review+

Attachments
Test case (5.46 KB, patch) 2011-07-22 04:11 EDT, Egidijus Vaisnora	no flags	Details \| Diff
Patch (6.24 KB, patch) 2011-07-22 04:17 EDT, Egidijus Vaisnora	no flags	Details \| Diff
Patch v2 (9.12 KB, patch) 2011-09-19 03:25 EDT, Eike Stepper	no flags	Details \| Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Egidijus Vaisnora

2011-07-22 04:10:04 EDT

Checking should work when local revision cache is not update from the revisions on server. After revision is serialized from server simple Java NULL value is replaced into CDOID.NULL. CommitIntegrityCheck treats this CDOID.NULL in CDOSetFeatureDelta as failure. 
It looks weird to have two kind of NULL values and definitely it will lead to bugs over and over, but it different story.

Comment 1 Egidijus Vaisnora

2011-07-22 04:11:32 EDT

Created attachment 200157 [details]
Test case

Comment 2 Egidijus Vaisnora

2011-07-22 04:17:02 EDT

Created attachment 200158 [details]
Patch

Comment 3 Eike Stepper

2011-09-19 03:25:50 EDT

Created attachment 203569 [details]
Patch v2

I changed the check slightly and added the test case to AllConfigs.java

Comment 4 Eike Stepper

2011-09-19 03:28:02 EDT

Please backport to 4.0 in bug 358062.

Comment 5 Egidijus Vaisnora

2011-09-19 04:14:41 EDT

Committed to trunk, revision 9175

Comment 6 Eike Stepper

2012-09-21 07:18:15 EDT

Closing.