Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 352795 - [expressions] Enable in-line editing of expression activated by File->Rename action.
Summary: [expressions] Enable in-line editing of expression activated by File->Rename ...
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf (show other bugs)
Version: 8.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 8.0.1   Edit
Assignee: Pawel Piech CLA
QA Contact: Pawel Piech CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-21 14:26 EDT by Pawel Piech CLA
Modified: 2011-07-21 16:04 EDT (History)
2 users (show)

See Also:
pawel.1.piech: review? (pchuong)

Attachments
Fix. (174.37 KB, patch)
2011-07-21 14:28 EDT, Pawel Piech CLA 		no flags Details | Diff
Patch after doing a pull... (1.91 KB, patch)
2011-07-21 14:32 EDT, Pawel Piech CLA 		pawel.1.piech: iplog-
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Piech CLA 2011-07-21 14:26:23 EDT 
The expression view added a feature which enables editing the expressions using the File->Rename action short-cut (F2).  It enables in-line cell editing when in column mode and dialog popup for no-columns mode.

However, this feature does not work for DSF because DSF uses its own column IDs. The attached patch would change one of the expression view column ID constants to match the platform name column ID.  The referred ID is in an internal class, however it's one of the internal classes that's become a de-facto API in platform and we'll make sure to provide backward compatibility in case they need to be changed.
Comment 1 Pawel Piech CLA 2011-07-21 14:28:26 EDT 
Created attachment 200113 [details]
Fix.
Comment 2 Pawel Piech CLA 2011-07-21 14:32:06 EDT 
Created attachment 200114 [details]
Patch after doing a pull...
Comment 3 Pawel Piech CLA 2011-07-21 14:44:46 EDT 
I pushed the fix to cdt8_0 and master.  Patrick please review.
Comment 4 CDT Genie CLA 2011-07-21 15:19:22 EDT 
*** cdt git genie on behalf of 352795 ***

    Bug 352795 - [expressions] Enable in-line editing of expression
    activated by File->Rename action.

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=48646a0cbda2b22e427a66848bf18969e32efd7b
Comment 5 CDT Genie CLA 2011-07-21 15:19:25 EDT 
*** cdt git genie on behalf of 352795 ***

    Bug 352795 - [expressions] Enable in-line editing of expression
    activated by File->Rename action.

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=fcaa5b68b9c5bb99fc101ffbaa37fb9d89599c73