Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 352758 - Update some private fields in some scanner parsers to protected
Summary: Update some private fields in some scanner parsers to protected
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-build (show other bugs)
Version: 7.0.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 8.0.1   Edit
Assignee: Vivian Kong CLA
QA Contact: Andrew Gvozdev CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-21 10:10 EDT by John Liu CLA
Modified: 2014-01-29 22:54 EST (History)
2 users (show)

See Also:

Attachments
This is the patch (6.57 KB, patch)
2011-07-21 11:06 EDT, John Liu CLA 		cdtdoug: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Liu CLA 2011-07-21 10:10:20 EDT 
Update some private fields in some scanner parsers to protected for inheriting them. These parsers are:

XlCSpecsConsoleParser, GCCScannerInfoConsoleParser, GCCSpecsConsoleParser and AbstractGCCBOPConsoleParser

I will attach a git patch for the code change. The change will be needed in cdt_7_0 and head stream. Please let know if anyone has any concern about this update.

Thanks, John
Comment 1 John Liu CLA 2011-07-21 11:06:14 EDT 
Created attachment 200100 [details]
This is the patch
Comment 2 Vivian Kong CLA 2011-07-21 11:14:26 EDT 
Andrew, can you please review John's patch?  Thanks!
Comment 3 Andrew Gvozdev CLA 2011-07-21 11:24:31 EDT 
(In reply to comment #2)
> Andrew, can you please review John's patch?  Thanks!
This patch looks acceptable, thanks.
Comment 4 Vivian Kong CLA 2011-07-21 13:18:04 EDT 
(In reply to comment #3)
> (In reply to comment #2)
> > Andrew, can you please review John's patch?  Thanks!
> This patch looks acceptable, thanks.

Thanks I'll check them in then!
Comment 5 Vivian Kong CLA 2011-07-21 13:27:30 EDT 
I'll apply the patch
Comment 6 Vivian Kong CLA 2011-07-21 13:38:23 EDT 
Applied to cdt_7_0, cdt_8_0 and HEAD.  Thanks John
Comment 7 CDT Genie CLA 2011-07-21 14:19:27 EDT 
*** cdt git genie on behalf of 352758 ***

    Bug 352758 - Update some private fields in some scanner parsers to
    protected

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=b04b352ac384a8aab6f1d96ded6b0eedd6e22330
Comment 8 CDT Genie CLA 2011-07-21 14:19:30 EDT 
*** cdt git genie on behalf of 352758 ***

    Bug 352758 - Update some private fields in some scanner parsers to
    protected
    Change-Id: Iea5c586088fa8045e9eb43dff7d43909c0181bd8

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=62fda09c134fa6b58909309d59f431a9f9fe0d2a
Comment 9 CDT Genie CLA 2011-07-21 14:19:36 EDT 
*** cdt git genie on behalf of 352758 ***

    Bug 352758 - Update some private fields in some scanner parsers to
    protected
    Change-Id: Iea5c586088fa8045e9eb43dff7d43909c0181bd8

[*] http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=f32349a738936db399fe64cfbf9097f8707e2d34