Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 352723 - The '?' icon on MessageDialog.openQuestion() for Arabic locale, is not mirrored
Summary: The '?' icon on MessageDialog.openQuestion() for Arabic locale, is not mirrored
Status: CLOSED DUPLICATE of bug 277390
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.4.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-SWT-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-21 06:44 EDT by Jaitirth Shirole CLA
Modified: 2011-07-21 08:07 EDT (History)
2 users (show)

See Also:


Attachments
The image file for the issue (9.95 KB, image/jpeg)
2011-07-21 07:51 EDT, Jaitirth Shirole CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jaitirth Shirole CLA 2011-07-21 06:44:08 EDT
Build Identifier: 3.4.2.M20090107-0800

I didn't find existing bugs on this issue & hence creating this bug report. I even tried downloading the Eclipse Bidi pack and that didn't show me the mirrored icon for this JFace Question dialog.
We're using JFace's MessageDialog.openQuestion() API and the dialog text, buttons are correctly mirrored for Arabic, but not the '?' icon on the dialog.
I looked at the JFaceResources.java#initializeDefaultImages(), which has line:
declareImage(bundle1, "dialog_help_image", "$nl$/icons/full/help.gif", org.eclipse.jface.dialogs.Dialog.class, "images/help.gif");
But, the mirrored help.gif was not found..

Reproducible: Always

Steps to Reproduce:
1. Run a plug-in, which would bring up question dialog using above API and check if the question mark icon is seen as mirrored for Arabic locale.
Comment 1 Remy Suen CLA 2011-07-21 07:43:29 EDT
This icon is provided by the OS.
Comment 2 Paul Webster CLA 2011-07-21 07:47:19 EDT
I don't think this one is provided by the OS, though.

PW
Comment 3 Jaitirth Shirole CLA 2011-07-21 07:51:43 EDT
Created attachment 200079 [details]
The image file for the issue

Adding the image to clarify the issue. I too don't think it to be coming from the OS.
Comment 4 Remy Suen CLA 2011-07-21 07:54:27 EDT
(In reply to comment #3)
> Created attachment 200079 [details]
> The image file for the issue
> 
> Adding the image to clarify the issue. I too don't think it to be coming from
> the OS.

That's coming from the OS.

See org.eclipse.jface.dialogs.IconAndMessageDialog.getQuestionImage().
Comment 5 Jaitirth Shirole CLA 2011-07-21 08:01:46 EDT
Ah...I see. Somehow didn't catch this before writing the bug and incorrectly went into JFaceResources.java. So, this turns out to be not an Eclipse bug then?
Comment 6 Remy Suen CLA 2011-07-21 08:05:17 EDT
(In reply to comment #5)
> So, this turns out to be not an Eclipse bug
> then?

Probably not unless there is some other Win32 API SWT can call to retrieve a mirrored version of that image.

I'm actually pretty sure this bug has been filed before but I can't find it.
Comment 7 Remy Suen CLA 2011-07-21 08:07:19 EDT
(In reply to comment #6)
> I'm actually pretty sure this bug has been filed before but I can't find it.

Oh, here we go.

*** This bug has been marked as a duplicate of bug 277390 ***