Community
Participate
Working Groups
EditorAreaDropAdapter should ignore the dropevent in case event.data is null. This can happend if other applications don't provide sufficient or no data at all in their events (eg. drag and drop a url from chromium on Linux). Related bugs: 349021: drag and drop does not work with Chrome on Linux https://bugs.eclipse.org/bugs/show_bug.cgi?id=349021 95105: [DND] DBCS3.3: DBCS named file drag&drop not function
Created attachment 200045 [details] patch .
Created attachment 200046 [details] mylyn/context/zip
I agree to protect the code but then we should do it for all potential cases and not just 'null' ==> simply replace the assert with if (event.data instanceof String[]) { open editor code } The bonus question is whether we should log this, as the source app is not behaving correctly. Reporting it could make it easier to detect the issue.
*** Bug 352814 has been marked as a duplicate of this bug. ***
About the bonus: I think we should rather let others participate in the dnd operation and delegate the event. But given the current infrastructure, I don't see a clean way to do this. See also comment #2 on bug 349021.
*** Bug 364878 has been marked as a duplicate of this bug. ***
Dani, there's already an 'event.data instanceof String[]' there, does that mean that we can close this bug ?
(In reply to Eric Moffatt from comment #7) > Dani, there's already an 'event.data instanceof String[]' there, does that > mean that we can close this bug ? Nope. That code is in an Assert and fails if 'event.data' in 'null' (that's this bug).
Created attachment 237376 [details] I faced the issue while was working on https://issues.jboss.org/browse/JBIDE-15499.
See also https://bugs.eclipse.org/bugs/show_bug.cgi?id=349021#c3
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. If the bug is still relevant, please remove the stalebug whiteboard tag.
