Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 352497 - Remove log message form Scope#getConstructor
Summary: Remove log message form Scope#getConstructor
Status: RESOLVED WONTFIX
Alias: None
Product: JSDT
Classification: WebTools
Component: General (show other bugs)
Version: 3.2.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Ian Tewksbury CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-19 14:44 EDT by Ian Tewksbury CLA
Modified: 2011-11-16 15:40 EST (History)
1 user (show)

See Also:

Attachments
Fix Patch (1.56 KB, patch)
2011-07-19 14:45 EDT, Ian Tewksbury CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Tewksbury CLA 2011-07-19 14:44:29 EDT 
I placed a log message in Scope#getConstructor in Bug 306958.  This log message fires any time more then one constructor is found for a given type.  I did not think this scenario was possible but I put in the log message just in case.  Turns out it is very possible and happens very often flooding the log with messages.

The log message should be removed and a new bug opened to figure out why there are more then one constructor for type and if it is legal.  Then if it is a legal situation what to do about it.
Comment 1 Ian Tewksbury CLA 2011-07-19 14:45:18 EDT 
Created attachment 199932 [details]
Fix Patch

Patch to remove log message.
Comment 2 Chris Jaun CLA 2011-07-19 14:47:35 EDT 
Shouldn't we figure out why there are multiple constructors?
Comment 3 Ian Tewksbury CLA 2011-07-19 14:48:00 EDT 
I opened bug 352498 to determine why there is more then on constructor and if it is a legal case or not.
Comment 4 Ian Tewksbury CLA 2011-07-19 14:49:12 EDT 
(In reply to comment #2)
> Shouldn't we figure out why there are multiple constructors?

Separate bug.  Now that we know this is a problem we should turn off the log message and determine what to do from here.  From a quick chat with Nitin he thinks this maybe legal.  But if it is then some things need to be changed around to handle it.  Such as Scope#getConstructor which is designed to only return one constructor.
Comment 5 Nitin Dahyabhai CLA 2011-09-15 13:26:16 EDT 
I think it's a good diagnostic to have around.  When we figure out the root cause, will reconsider applying.