Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 352462 - [Compatibility] F1 does nothing in the 'Git Staging' view
Summary: [Compatibility] F1 does nothing in the 'Git Staging' view
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.1   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 4.1.1   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 331240
  Show dependency tree
 
Reported: 2011-07-19 10:15 EDT by Remy Suen CLA
Modified: 2011-08-26 09:35 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2011-07-19 10:15:10 EDT 
Pressing F1 seems to do nothing in the 'Git Staging' view.

Strictly speaking, the content isn't of interest it just says the following in 3.x (which seems to be completely useless):

About Git Staging
Each workbench window contains one or more perspectives, which are made up of various views and editors.
Comment 1 Remy Suen CLA 2011-07-19 10:33:17 EDT 
(In reply to comment #0)
> About Git Staging
> Each workbench window contains one or more perspectives, which are made up of
> various views and editors.

Unsurprisingly, on 3.x it is the shell that is getting the help event. This would explain why we're getting information about the workbench window.
Comment 2 Remy Suen CLA 2011-07-19 13:18:44 EDT 
We had no contextual help setup for the workbench window's shell so we were not presenting any information when the help event recursed up to the shell.

Fix released to R4_development in 5eec2b04a70f704a7cdc1b77db59bb90ec03dd68.
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_development&id=5eec2b04a70f704a7cdc1b77db59bb90ec03dd68
Comment 3 Dani Megert CLA 2011-07-20 04:00:43 EDT 
Did you file a bug against EGit to actually provide some useful help?
Comment 4 Remy Suen CLA 2011-07-20 06:13:21 EDT 
(In reply to comment #3)
> Did you file a bug against EGit to actually provide some useful help?

That I haven't. I think the philosophy there is to rely on the wiki for everything.
Comment 5 Dani Megert CLA 2011-07-20 06:16:02 EDT 
(In reply to comment #4)
> (In reply to comment #3)
> > Did you file a bug against EGit to actually provide some useful help?
> 
> That I haven't. I think the philosophy there is to rely on the wiki for
> everything.

Then there F1 help should say that including a link to the wiki - preferably to the section that describes the corresponding UI element.
Comment 6 Remy Suen CLA 2011-08-26 09:35:52 EDT 
Verified with M20110817-2001 on Windows XP.