Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 352439 - Prefetch revision ends with IllegalArgumentException
Summary: Prefetch revision ends with IllegalArgumentException
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.core (show other bugs)
Version: 4.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Eike Stepper CLA
QA Contact: Eike Stepper CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-19 07:05 EDT by Egidijus Vaisnora CLA
Modified: 2012-09-21 07:16 EDT (History)
1 user (show)

See Also:

Attachments
Patch (718 bytes, patch)
2011-07-19 07:45 EDT, Egidijus Vaisnora CLA 		no flags Details | Diff
Fix v2 (732 bytes, patch)
2011-08-04 02:30 EDT, Eike Stepper CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Egidijus Vaisnora CLA 2011-07-19 07:05:58 EDT 
Prefetch code doesn't assume that CDOIDNull could be encountered:
java.lang.IllegalStateException: No type found for NULL
	at org.eclipse.emf.cdo.server.internal.db.DBStoreAccessor.getObjectType(DBStoreAccessor.java:200)
	at org.eclipse.emf.cdo.server.internal.db.DBStoreAccessor.readRevision(DBStoreAccessor.java:213)
	at org.eclipse.emf.cdo.internal.server.Repository.loadRevisions(Repository.java:439)
	at org.eclipse.emf.cdo.internal.common.revision.CDORevisionManagerImpl.loadRevisions(CDORevisionManagerImpl.java:365)
	at org.eclipse.emf.cdo.internal.common.revision.CDORevisionManagerImpl.getRevisions(CDORevisionManagerImpl.java:276)
	at org.eclipse.emf.cdo.internal.common.revision.CDORevisionManagerImpl.getRevision(CDORevisionManagerImpl.java:259)
	at org.eclipse.emf.cdo.internal.common.revision.CDORevisionManagerImpl.getRevision(CDORevisionManagerImpl.java:252)
	at org.eclipse.emf.cdo.server.internal.net4j.protocol.LoadRevisionsIndication.getRevision(LoadRevisionsIndication.java:205)
	at org.eclipse.emf.cdo.server.internal.net4j.protocol.LoadRevisionsIndication.prefetchRevisionChild(LoadRevisionsIndication.java:325)
	at org.eclipse.emf.cdo.server.internal.net4j.protocol.LoadRevisionsIndication.prefetchRevision(LoadRevisionsIndication.java:297)
	at org.eclipse.emf.cdo.server.internal.net4j.protocol.LoadRevisionsIndication.prefetchRevisionChild(LoadRevisionsIndication.java:332)
	at org.eclipse.emf.cdo.server.internal.net4j.protocol.LoadRevisionsIndication.prefetchRevision(LoadRevisionsIndication.java:310)
	at org.eclipse.emf.cdo.server.internal.net4j.protocol.LoadRevisionsIndication.prefetchRevisions(LoadRevisionsIndication.java:278)
	at org.eclipse.emf.cdo.server.internal.net4j.protocol.LoadRevisionsIndication.responding(LoadRevisionsIndication.java:179)
	at org.eclipse.emf.cdo.server.internal.net4j.protocol.CDOServerIndication.responding(CDOServerIndication.java:133)
	at org.eclipse.net4j.signal.IndicationWithResponse.doExtendedOutput(IndicationWithResponse.java:96)
	at org.eclipse.net4j.signal.Signal.doOutput(Signal.java:296)
	at org.eclipse.net4j.signal.IndicationWithResponse.execute(IndicationWithResponse.java:65)
	at org.eclipse.emf.cdo.server.internal.net4j.protocol.CDOServerReadIndication.execute(CDOServerReadIndication.java:36)
	at org.eclipse.net4j.signal.Signal.runSync(Signal.java:251)
	at org.eclipse.net4j.signal.Signal.run(Signal.java:147)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
	at java.lang.Thread.run(Thread.java:680)
Comment 1 Egidijus Vaisnora CLA 2011-07-19 07:45:40 EDT 
Created attachment 199892 [details]
Patch

Fix to prevent loading revision with NULL ID
Comment 2 Eike Stepper CLA 2011-08-04 02:30:13 EDT 
Created attachment 200877 [details]
Fix v2

Changed to CDOIDUtil.isNull()
Comment 3 Eike Stepper CLA 2011-08-04 02:30:42 EDT 
Assigning to myself because Egidijus is on vacation.
Comment 4 Eike Stepper CLA 2011-08-04 02:30:54 EDT 
Committed revision 8859:
- trunk/plugins/org.eclipse.emf.cdo.server.net4j
Comment 5 Eike Stepper CLA 2011-08-04 02:31:15 EDT 
Resolved
Comment 6 Eike Stepper CLA 2012-09-21 07:16:12 EDT 
Closing.