Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 352226 - GenerationQueue should use project info cache to locate .egl file
Summary: GenerationQueue should use project info cache to locate .egl file
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Justin Spadea CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-15 11:30 EDT by Justin Spadea CLA
Modified: 2017-02-23 14:19 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Spadea CLA 2011-07-15 11:30:09 EDT 
If we couldn't locate the IR for a qualified part name (e.g. deserialization exception), then we attempt to find the .egl file so that we can create error markers on the resource. Right now the code just iterates through the source folders doing a case-insensitive search for a file whose name is pkg/part.egl. This won't work for all part types though - a record, for example, can be in a file whose name does not match the record part name (blah.egl can contain record foorec).

We should use the ProjectInfo cache to locate the .egl file. Not only will this work in all cases, but it'll be faster.
Comment 1 Justin Spadea CLA 2011-07-18 16:23:11 EDT 
Changed GenerationQueue.java to use the ProjectInfo for locating the .egl file. This means we can check if the part has any generators earlier, and if it doesn't then we can skip deserializing it from disk.
Comment 2 Justin Spadea CLA 2011-09-13 15:31:26 EDT 
Verified