Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 352220 - Possibility to disable guides
Summary: Possibility to disable guides
Status: CLOSED FIXED
Alias: None
Product: Graphiti
Classification: Modeling
Component: Core (show other bugs)
Version: 0.7.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 0.9.0   Edit
Assignee: Michael Wenz CLA
QA Contact:
URL:
Whiteboard: Juno M2 Theme_round_offs
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-15 10:41 EDT by Harald Stangl CLA
Modified: 2012-06-28 10:41 EDT (History)
2 users (show)

See Also:
michael.wenz: juno+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Stangl CLA 2011-07-15 10:41:52 EDT 
It should be possible to disable the automatic displaying of and aligning to the guides that show up when you move and/or resize elements on a diagram.
Comment 1 Michael Wenz CLA 2011-07-19 04:21:59 EDT 
Would like to target for Juno
Comment 2 Harald Stangl CLA 2011-07-20 04:31:32 EDT 
Could you please provide information about where to fix this manually in the meantime?
Comment 3 Michael Wenz CLA 2011-07-20 07:47:42 EDT 
While checking for a possibility I found that there is a method isShowGuides() in the tool behavior provider that you can override to return false and disables the guides in the diagram.

That finding reduces this bug to checking why there is an additional field at the diagram object which is never queried and eventually deleting that field.

Michael
Comment 4 Michael Wenz CLA 2011-09-16 04:46:58 EDT 
If guides shall be shown is controlled by the method isShowGuides() in thr tool behaviour provider.
The attribute showGuides at the diagram object is not necessary. Unfortunatly it cannot be removed completely, otherwise old diagrams cannot be read any more.
I have kept the attribute in Diagram, but marked it as deprecated and have removed the getter and setter methods for it.

Checked in to head and pushed to Eclipse:
commit 2fd76f7e0dc0b263504285ebdc785c56a182a1c1
Author: mwenz <michael.wenz@sap.com> 2011-09-16 10:19:42
Committer: mwenz <michael.wenz@sap.com> 2011-09-16 10:19:42
Parent: cd4b4c16f51dc7aafd4913ff01464e1445d0e155 (Corrected localization setting)
Child: bf2a2d4bfcb8b8c0cde70798c80a1f327f2fd947 (Bug 352220 - Corrected documentation)
Child: d200362f81239a1b5efc64b4a717ff741d759906 (Bug 357411 - Remove ugly reflection code to get IFile from IFileEditorInput (contribution by Hernan))
Branches: origin/master, Bug357411, master

commit bf2a2d4bfcb8b8c0cde70798c80a1f327f2fd947
Author: mwenz <michael.wenz@sap.com> 2011-09-16 10:45:47
Committer: mwenz <michael.wenz@sap.com> 2011-09-16 10:45:47
Parent: 2fd76f7e0dc0b263504285ebdc785c56a182a1c1 (Bug 352220 - Removed attribute to disable guides from diagram (as far as possible without breaking old diagrams))
Branches: origin/master, master
Comment 5 Michael Wenz CLA 2012-04-11 10:33:52 EDT 
Bookkeeping: Set target release
Comment 6 Michael Wenz CLA 2012-06-28 10:41:15 EDT 
Part of Graphiti 0.9.0 (Eclipse Juno)