Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 352214 - ResourceDescriptionsBasedContainer descriptionsChanged should not create nulled IResourceDescriptions
Summary: ResourceDescriptionsBasedContainer descriptionsChanged should not create null...
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 2.0.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: SR1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-15 09:57 EDT by Mark Christiaens CLA
Modified: 2017-09-19 18:17 EDT (History)
1 user (show)

See Also:
sebastian.zarnekow: indigo+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Christiaens CLA 2011-07-15 09:57:56 EDT 
Build Identifier: 20110615-0604

When a clean build occurs then ResourceDescriptionsBasedContainer.descriptionsChanged(Event) receives deltas that have delta.getNew () == null.  That null enters the uriToDescription map.  That in turn causes getResourceDescriptions() to return an Iterable containing nulls.  That causes an NPE in for example  org.eclipse.xtext.resource.containers.FilterUriContainer.getResourceDescriptions().

Reproducible: Always
Comment 1 Mark Christiaens CLA 2011-07-15 10:15:01 EDT 
BTW, I'm trying to inject my way out of this but I notice I need org.eclipse.xtext.resource.containers.ContainerState to do so.  That class is package private.  Is that intentional?
Comment 2 Sebastian Zarnekow CLA 2011-07-15 10:20:38 EDT 
No, the package private class is not intentional. Fortunately it's easy to implement (read: copy) the IContainerState on your own :-/
Comment 3 Sebastian Zarnekow CLA 2011-07-25 12:47:56 EDT 
Pushed to master.
Comment 4 Karsten Thoms CLA 2017-09-19 18:08:22 EDT 
Closing all bugs that were set to RESOLVED before Neon.0
Comment 5 Karsten Thoms CLA 2017-09-19 18:17:50 EDT 
Closing all bugs that were set to RESOLVED before Neon.0