Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 352186 - [Theming] Enhance Scale theming
Summary: [Theming] Enhance Scale theming
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.4   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.0 M4   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-15 04:48 EDT by Ivan Furnadjiev CLA
Modified: 2014-12-10 06:06 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Furnadjiev CLA 2011-07-15 04:48:43 EDT 
There is a lot of room for Scale theming enhancement:
1. add background-image property (gradient) to Scale and Scale-Thumb( ??? currently the thumb is Image widget ).
2. add border, border-radius for Scale-Thumb( ??? currently the thumb is Image widget ).
3. add HORIZONTAL/VERTICAL style to both Scale and Scale-Thumb.
4. make the ruler images themeable.
5. make the thumb images themeable ( ??? currently the thumb is Image widget ).
6. add hover state for the thumb.
If it help us for more flexible styling we can consider to change the client side thumb implementation from Image to BasicButton (like in Slider).
Comment 1 Ivan Furnadjiev CLA 2011-09-28 05:15:19 EDT 
Changed scale thumb client-side widget to BasicButton. Added themable properties border and border-radius. Removed unused tumb images.
Comment 2 Nick Mussin CLA 2011-10-11 06:22:22 EDT 
Further enhancements proposal:

(maybe) introduce a "Scale-Rail" element in Scale.theme.xml to make the "rail" of the Scale themable:

- at least, make the background-image of the rail exchangeable. 

- better: add background-image, background-color, border, border-radius and box-shadow (including "inset" keyword)



Also, further extend Scale-Thumb:
add background-image to enable pattern images and gradients
Comment 3 Nick Mussin CLA 2011-10-11 06:25:53 EDT 
...add height and width to Scale-Thumb, as well.
Comment 4 Ivan Furnadjiev CLA 2011-11-01 04:32:10 EDT 
We decided to remove the ruler markers completely. Changes are in CVS HEAD.
Comment 5 Ivan Furnadjiev CLA 2014-12-10 06:06:11 EST 
Fixed with change https://git.eclipse.org/r/#/c/37460/.